Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding manual + fix docker #123

Merged
merged 12 commits into from
May 22, 2024
Merged

adding manual + fix docker #123

merged 12 commits into from
May 22, 2024

Conversation

antiyro
Copy link
Member

@antiyro antiyro commented May 20, 2024

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing
  • Other (please describe):

What is the current behavior?

Resolves: #NA

What is the new behavior?

Does this introduce a breaking change?

Other information

@antiyro antiyro requested review from jbcaron and cchudant May 21, 2024 13:56
Dockerfile Outdated
clang \
protobuf-compiler \
build-essential && \
apt-get autoremove -y && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not necessary on the builder to clean

Dockerfile Outdated
@@ -1,17 +1,42 @@
FROM rust:slim-buster
# Stage 1: Build the application
FROM rust:slim-buster AS builder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use directly rust:version

Dockerfile Outdated

ENTRYPOINT ["./target/production/deoxys"]
# Stage 2: Create the final runtime image
FROM debian:buster-slim
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update to debian:bookworm-slim

Dockerfile Outdated
rm -rf /var/lib/apt/lists/*

# Set the working directory
WORKDIR /usr/src/deoxys
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer the /usr/local/bin directory for binary

--l1-endpoint ${ETHEREUM_API_URL}
--network main
--chain starknet
--rpc-port ${RPC_PORT:-9944}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should keep 9944

@antiyro antiyro merged commit 43e4194 into main May 22, 2024
9 checks passed
@antiyro antiyro deleted the fix/docker branch June 10, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants