-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding manual + fix docker #123
Conversation
Dockerfile
Outdated
clang \ | ||
protobuf-compiler \ | ||
build-essential && \ | ||
apt-get autoremove -y && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not necessary on the builder to clean
Dockerfile
Outdated
@@ -1,17 +1,42 @@ | |||
FROM rust:slim-buster | |||
# Stage 1: Build the application | |||
FROM rust:slim-buster AS builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use directly rust:version
Dockerfile
Outdated
|
||
ENTRYPOINT ["./target/production/deoxys"] | ||
# Stage 2: Create the final runtime image | ||
FROM debian:buster-slim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update to debian:bookworm-slim
Dockerfile
Outdated
rm -rf /var/lib/apt/lists/* | ||
|
||
# Set the working directory | ||
WORKDIR /usr/src/deoxys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prefer the /usr/local/bin directory for binary
docker-compose.yml
Outdated
--l1-endpoint ${ETHEREUM_API_URL} | ||
--network main | ||
--chain starknet | ||
--rpc-port ${RPC_PORT:-9944} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should keep 9944
Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:
What is the current behavior?
Resolves: #NA
What is the new behavior?
Does this introduce a breaking change?
Other information