Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/rpc #119

Merged
merged 27 commits into from
May 21, 2024
Merged

Fix/rpc #119

merged 27 commits into from
May 21, 2024

Conversation

jbcaron
Copy link
Member

@jbcaron jbcaron commented May 15, 2024 •
edited
Loading

Pull Request type

  • Bugfix

What is the current behavior?

What is the new behavior?

  • fix error handling for:
    • get_class_hash_at
    • get_nonce
    • get_storage_at
    • get_transction_by_block_id_and_index
    • get_transction_by_hash
  • simplifying error handling with substrate_block_hash_from_starknet_block
  • explicit use of thiserror::Error
  • clean: pallet/starknet

Does this introduce a breaking change?

Other information

TODO

  • fix: get_transaction_status

@jbcaron jbcaron self-assigned this May 16, 2024
@jbcaron jbcaron marked this pull request as ready for review May 16, 2024 15:53
@jbcaron jbcaron requested a review from antiyro May 16, 2024 15:53
antiyro
antiyro approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@antiyro antiyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging approved

@jbcaron jbcaron requested review from cchudant May 20, 2024 18:09
@antiyro antiyro merged commit 5022800 into madara-alliance:main May 21, 2024
7 checks passed
@jbcaron jbcaron deleted the fix/rpc branch May 23, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antiyro antiyro antiyro approved these changes

@cchudant cchudant Awaiting requested review from cchudant

Assignees

@jbcaron jbcaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbcaron @antiyro