Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/queue builder #94

Closed
wants to merge 5 commits into from
Closed

Update/queue builder #94

wants to merge 5 commits into from

Conversation

heemankv
Copy link
Contributor

This PR adds two functions new and new_from_env for SqsQueue.

Previously only env vars were read to assign queue's endpoint_url.
This allows to programatically provide the endpoint_url.

@heemankv heemankv self-assigned this Aug 21, 2024
@coveralls
Copy link

coveralls commented Aug 21, 2024

Coverage Status

coverage: 56.33% (-0.07%) from 56.401%
when pulling 80af8ef on update/queue-builder
into 7e771e7 on main.

AWS_DEFAULT_REGION="localhost"

#### QUEUE ####
# Add without trailing slash, to be handled wherever used.
QUEUE_BASE_URL = "http://sqs.us-east-1.localhost.localstack.cloud:4566/000000000000"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update .env.example as well

@apoorvsadana
Copy link
Contributor

Closing in favor of #96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants