Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add panic recovery handling for process_job with test coverage #178

Merged
merged 12 commits into from
Nov 9, 2024

Conversation

Mohiiit
Copy link
Contributor

@Mohiiit Mohiiit commented Nov 6, 2024

Description:

Added graceful panic recovery mechanism to process_job to prevent system crashes and ensure proper error handling. This enhancement improves system stability and maintainability.

Changes:

  • Implemented panic recovery using defer/recover pattern in process_job
  • The job will move to failed state in the panic case

Test Coverage:

  • Added test cases to verify panic scenarios are properly caught and handled
  • Verified error is returned instead of propagating the panic

@coveralls
Copy link

coveralls commented Nov 6, 2024

Coverage Status

coverage: 69.316% (-0.01%) from 69.327%
when pulling c17d7a9 on feat/panic-handling
into 803be5f on main.

crates/orchestrator/src/jobs/mod.rs Outdated Show resolved Hide resolved
Copy link
Member

@ocdbytes ocdbytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !!

@apoorvsadana apoorvsadana merged commit c66c0f3 into main Nov 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants