Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Makefile #177

Merged
merged 4 commits into from
Nov 6, 2024
Merged

Refactor: Makefile #177

merged 4 commits into from
Nov 6, 2024

Conversation

Mohiiit
Copy link
Contributor

@Mohiiit Mohiiit commented Nov 5, 2024

Description

This PR includes several improvements to our build and configuration systems:

  1. Updated bootstraper dependency in the Makefile to the latest version
  2. Enhanced the update-json script functionality and now it accepts any JSON file as input (previously limited to fixed file)
  3. Fixed config hash issues through the updated bootstraper

@coveralls
Copy link

coveralls commented Nov 5, 2024 •
edited
Loading

Coverage Status

coverage: 68.93%. remained the same
when pulling 16f065f on refactor/makefile
into 4d61e3a on main.

apoorvsadana
apoorvsadana approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@apoorvsadana apoorvsadana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ocdbytes
ocdbytes reviewed Nov 6, 2024
View reviewed changes
Copy link
Member

@ocdbytes ocdbytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed. Everything else looks good to me.

bootstrap_input.json Show resolved Hide resolved
@Mohiiit Mohiiit merged commit ac131a5 into main Nov 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoorvsadana apoorvsadana apoorvsadana approved these changes

@ocdbytes ocdbytes ocdbytes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mohiiit @coveralls @ocdbytes @apoorvsadana