Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Snos job #122

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

feat: Snos job #122

wants to merge 25 commits into from

Conversation

akhercha
Copy link
Member

@akhercha akhercha commented Sep 13, 2024 •
edited
Loading

Resolves: #11

Follow-up of: #105

Added

  • Implementation of the SnosJob.

Updated

  • toolchain to nightly so it matches the one used in the snos repository. It caused a lot of lint updates, hence all the files updated in this PR,
  • some package versions so they're compatible with snos.

@akhercha
feat(snos_job): Dependencies updated for Snos
d56748f
@akhercha
feat(snos_job): Non-working state but prove_block added
810d7dc
@akhercha
feat(snos_job): Added storage for snos
3df5787
@akhercha
feat(snos_job):
95d3667
@akhercha
feat(snos_job): Stores the CairoPie as zip
7e3e219
@akhercha
feat(snos_job): Docs
15f39a0
@akhercha
feat(snos_job): Minor stuff
37917be
@akhercha
feat(snos_job): First set of simple tests
35571a5
@akhercha
feat(snos_job): Comitting the error
93079f7
@akhercha
feat(snos_job): Fixed stuff after rebase
d8af55f
@akhercha
feat(snos_job): Lint stuff
3966e75
@akhercha
feat(snos_job): Push the bug
15d5af3
@akhercha
feat(snos_job): Compiling
0d9ae35 
gpush
@akhercha
feat(snos_job): Sync with main
91195df
@akhercha
feat(snos_job): Fixed stuff
a1f62ca
@akhercha
feat(snos_job): Nightly toolchain for CI
2359bc0
@akhercha
feat(snos_job): Mock process snos job
9232338
@akhercha
feat(snos_job):
4f2f213
@akhercha
feat(snos_job):
861aad8
@akhercha
feat(snos_job): Smol fixes from review
69bb525
@akhercha
feat(snos_job): Unwrap killed
6eae825
@akhercha akhercha self-assigned this Sep 13, 2024
@akhercha akhercha mentioned this pull request Sep 13, 2024
Closed
@coveralls
Copy link

coveralls commented Sep 13, 2024 •
edited
Loading

Coverage Status

coverage: 64.404% (-0.3%) from 64.692%
when pulling dd368ac on feat/snos_job
into 05e8acb on main.

@apoorvsadana
Copy link
Contributor

This looks good. The e2e seems to fail, @ocdbytes is looking into it and he will create a PR to add SNOS run in the e2e. After that we can merge this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@akhercha akhercha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement SNOS job
3 participants
@akhercha @coveralls @apoorvsadana