Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inserts remove leaks #34

Merged
merged 19 commits into from
Sep 17, 2024

Conversation

cchudant
Copy link
Member

  • Added proptest
  • Proptest showed a number of fun bugs, which I fixed
  • Added a check to see if trie nodes are leaked to the proptest, which showed me a lot of cases where they are not, which i fixed
  • Node type Unresolved was removed (init_tree does nothing now)
  • The bonsai trie now syncs properly with sepolia and mainnet

Smallvec pr should be merged before this one, and i'll rebase this one afterward on main
Opening as draft because bonsai log is probably broken, i havent tested, and uncommited tx needs to be fixed -- I don't have time to fix those at the moment

@AurelienFT

@cchudant cchudant marked this pull request as ready for review September 16, 2024 12:28
@cchudant
Copy link
Member Author

closes #31

@cchudant cchudant merged commit 56d7d62 into madara-alliance:oss Sep 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant