perf: make binary nodes compute their edges in parallel #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiyro
approved these changes
Apr 3, 2024
AurelienFT
approved these changes
Apr 4, 2024
antiyro
approved these changes
Apr 11, 2024
|
@tdelabro I have applied your suggestions :) |
tdelabro
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
I originally opened this PR here: massalabs#4 so that I could show it to @AurelienFT until multi trie is merged on this repo
During the commit of a MerkleTree, when we encounter a Binary node, we can compute the hash of both of the edges in parallel. It turns out, this speeds up the crate quite a lot
I also tried optimizing a little bit more: get a bit lower level with a rayon::join_context in a way that allows to reuse the destination array without having to make a new local one if the compute job for the right path did not get stolen
unfortunately it's unclear whether it has any impact on what the benches tell me so it's not included in the pr
it might because the machine I am currently using for benching has high variation in the results, i might reexplore this at some point