A few more new python ports #20370

catap · 2023-09-09T22:16:32Z

Description

Goal: statisfy dependencies for osxphotos.

Some ports has also @RhetTbull as co-mainaner which was cleared with him.

Type(s)

enhancement

Tested on

macOS 12.6.8 21G725 x86_64
Xcode 14.2 14C18

Verification

Have you

followed our Commit Message Guidelines?
squashed and minimized your commits?
checked that there aren't other open pull requests for the same change?
checked your Portfile with port lint --nitpick?
tried existing tests with sudo port test?
tried a full install with sudo port -vst install?
tested basic functionality of all binary files?

macportsbot · 2023-09-09T22:16:35Z

Notifying maintainers:
@petrrr for port py-bitarray.

reneeotten

question regarding "platforms" line pertains to each Portfile

reneeotten · 2023-09-09T22:18:41Z

python/py-applescript/Portfile

+version             1.0.3
+revision            0
+
+supported_archs     noarch


this should probably then as well add "platforms {darwin any}"

reneeotten · 2023-09-09T22:20:01Z

python/py-bitstring/Portfile

-
-   livecheck.type   none
+   # test.dir         ${worksrcpath}/test
+   # test.cmd         ${python.bin} -m unittest discover


please remove these commented out lines

reneeotten · 2023-09-09T22:21:16Z

python/py-osxmetadata/Portfile

+version                     1.3.0
+revision                    0
+
+supported_archs             noarch


also needs "platforms {darwin any}"?

reneeotten · 2023-09-09T22:21:46Z

python/py-photoscript/Portfile

+version                 0.3.0
+revision                0
+
+supported_archs         noarch


same question as above for platforms line

reneeotten · 2023-09-09T22:22:03Z

python/py-pytimeparse2/Portfile

+revision            0
+
+categories-append   devel
+supported_archs     noarch


platforms line?

reneeotten · 2023-09-09T22:22:30Z

python/py-rich-theme-manager/Portfile

+revision                    0
+
+categories-append           devel
+supported_archs             noarch


plaforms line?

catap · 2023-09-09T22:40:29Z

@reneeotten fixed everything. I hope.

Meanwhile, I've opened macports/upt-macports#74 to avoid that issue in the future

catap · 2023-09-10T22:31:08Z

Rebased to exclude update py-arpeggio because it was already made

catap · 2023-09-11T16:49:35Z

@reneeotten ?

reneeotten · 2023-09-11T18:22:10Z

I'll look tonight after work

catap · 2023-09-11T18:58:20Z

Thanks!

reneeotten

sorry, one more question; other than that this is ready to merge

reneeotten · 2023-09-12T02:26:23Z

python/py-bitarray/Portfile

-    pre-test {
-        test.env    PYTHONPATH=[glob -nocomplain ${worksrcpath}/build/lib*]
-    }
-
    test.run        yes


do the tests run in this way? I would think you have to set python.test_framework to an empty string as otherwise it will assume pytest and add test.args that will probably now work with the way tests are called here. Removing test.target should be fine though.

@reneeotten yes, I’ve run tests this way

---> Computing dependencies for py311-bitarray. ---> Testing py311-bitarray Executing: cd "/opt/local/var/macports/build/_Users_catap_src_macports-ports_python_py-bitarray/py311-bitarray/work/bitarray-2.8.1" && /opt/local/Library/Frameworks/Python.framework/Versions/3.11/bin/python3.11 bitarray/test_bitarray.py -o addopts='' /opt/local/var/macports/build/_Users_catap_src_macports-ports_python_py-bitarray/py311-bitarray/work/bitarray-2.8.1/bitarray/test_bitarray.py:5057: DeprecationWarning: unittest.makeSuite() is deprecated and will be removed in Python 3.13. Please use unittest.TestLoader.loadTestsFromTestCase() instead. suite.addTest(unittest.makeSuite(cls)) ............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................ ---------------------------------------------------------------------- Ran 492 tests in 0.666s OK bitarray is installed in: /opt/local/var/macports/build/_Users_catap_src_macports-ports_python_py-bitarray/py311-bitarray/work/bitarray-2.8.1/bitarray bitarray version: 2.8.1 sys.version: 3.11.5 (main, Aug 25 2023, 01:35:05) [Clang 13.1.6 (clang-1316.0.21.2.5)] sys.prefix: /opt/local/Library/Frameworks/Python.framework/Versions/3.11 pointer size: 64 bit sizeof(size_t): 8 sizeof(bitarrayobject): 80 __clang__ or __GNUC__ defined: 1 PY_LITTLE_ENDIAN (use word shift): 1 DEBUG: 0

But idea to add python.test_framework with empty string is good one, it allows to remove useless dependency, let me do it.

thanks, you can also see that without that addition it added "-o addopts=" which is a outest flag that shouldn't be added here.

macportsbot assigned petrrr Sep 9, 2023

macportsbot added type: enhancement type: submission maintainer: open Affects an openmaintainer port labels Sep 9, 2023

reneeotten requested changes Sep 9, 2023

View reviewed changes

catap force-pushed the osxphotos branch from 16d0f65 to 2173bc7 Compare September 9, 2023 22:40

catap requested a review from reneeotten September 9, 2023 22:40

catap mentioned this pull request Sep 10, 2023

Create MacPorts portfile for osxphotos RhetTbull/osxphotos#1200

Closed

catap force-pushed the osxphotos branch from 2173bc7 to 2147fbb Compare September 10, 2023 22:30

catap force-pushed the osxphotos branch from 2147fbb to e0324da Compare September 10, 2023 22:54

reneeotten reviewed Sep 12, 2023

View reviewed changes

catap requested a review from reneeotten September 12, 2023 20:19

catap added 10 commits September 13, 2023 00:31

py-bitarray: update to 2.8.1

7cc5d20

py-bitstring: update to 4.1.2; claim maintainership

79f9c90

py-applescript: new port (version 1.0.3)

0d535b1

py-osxmetadata: new port (version 1.3.0`)

1acc6b0

py-pytimeparse2: new port (version 1.7.1)

ee1f7eb

py-rich-theme-manager: new port (version 0.11.0)

0b1ef66

py-photoscript: new port (version 0.3.0)

ff05238

py-shortuuid: new port (version 1.0.11)

5ef907c

py-textx: new port (version 3.1.1)

7cd3b5e

py-strpdatetime: new port (version 0.2.0)

dd5e073

catap force-pushed the osxphotos branch from e0324da to dd5e073 Compare September 12, 2023 22:31

reneeotten merged commit dead657 into macports:master Sep 12, 2023
3 checks passed

catap deleted the osxphotos branch September 13, 2023 06:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

A few more new python ports #20370

A few more new python ports #20370

catap commented Sep 9, 2023

macportsbot commented Sep 9, 2023

reneeotten left a comment

reneeotten Sep 9, 2023

reneeotten Sep 9, 2023

reneeotten Sep 9, 2023

reneeotten Sep 9, 2023

reneeotten Sep 9, 2023

reneeotten Sep 9, 2023

catap commented Sep 9, 2023

catap commented Sep 10, 2023

catap commented Sep 11, 2023

reneeotten commented Sep 11, 2023

catap commented Sep 11, 2023

reneeotten left a comment

reneeotten Sep 12, 2023

catap Sep 12, 2023

catap Sep 12, 2023

catap Sep 12, 2023

catap Sep 12, 2023

reneeotten Sep 12, 2023

A few more new python ports #20370

A few more new python ports #20370

Conversation

catap commented Sep 9, 2023

Description

Type(s)

Tested on

Verification

macportsbot commented Sep 9, 2023

reneeotten left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

catap commented Sep 9, 2023

catap commented Sep 10, 2023

catap commented Sep 11, 2023

reneeotten commented Sep 11, 2023

catap commented Sep 11, 2023

reneeotten left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment