Merge branch 'master' into release

manifest.json

@@ -1,7 +1,7 @@
 {
 	"id": "obsidian-meta-bind-plugin",
 	"name": "Meta Bind Plugin",
-	"version": "0.5.0",
+	"version": "0.5.1",
 	"minAppVersion": "0.14.0",
 	"description": "This plugin can create input fields inside your notes and bind them to metadata fields.",
 	"author": "Moritz Jung",

package.json

@@ -1,6 +1,6 @@
 {
 	"name": "obsidian-meta-bind-plugin",
-	"version": "0.5.0",
+	"version": "0.5.1",
 	"description": "This plugin can create input fields inside your notes and bind them to metadata fields.",
 	"main": "main.js",
 	"scripts": {

src/renderChildren/JsViewFieldMDRC.ts

@@ -1,5 +1,5 @@
 import MetaBindPlugin from '../main';
-import { ErrorLevel, MetaBindExpressionError } from '../utils/errors/MetaBindErrors';
+import { ErrorLevel, MetaBindExpressionError, MetaBindJsError } from '../utils/errors/MetaBindErrors';
 import { Listener, Signal } from '../utils/Signal';
 import { RenderChildType } from './InputFieldMDRC';
 import { JsViewFieldDeclaration } from '../parsers/ViewFieldDeclarationParser';
@@ -82,10 +82,10 @@ export class JsViewFieldMDRC extends AbstractViewFieldMDRC {
 
 	async evaluateExpression(): Promise<string> {
 		if (!this.expression) {
-			throw new Error("Can't evaluate expression. Expression is undefined.");
+			throw new MetaBindJsError(ErrorLevel.CRITICAL, "Can't evaluate expression.", 'Expression is undefined.');
 		}
-		if (!(this.plugin instanceof MetaBindPlugin)) {
-			throw new Error("Can't evaluate expression. JS expressions are unsupported outside of obsidian.");
+		if (!this.plugin.settings.enableJs) {
+			throw new MetaBindJsError(ErrorLevel.CRITICAL, "Can't evaluate expression.", 'JS expressions are disabled in the plugin settings.');
 		}
 
 		const context = this.buildContext();

src/settings/Settings.ts

@@ -53,6 +53,7 @@ export interface MetaBindPluginSettings {
 	syncInterval: number;
 	maxSyncInterval: number;
 	minSyncInterval: number;
+	enableJs: boolean;
 
 	inputTemplates: string;
 }
@@ -66,6 +67,7 @@ export const DEFAULT_SETTINGS: MetaBindPluginSettings = {
 	syncInterval: 200,
 	minSyncInterval: 50,
 	maxSyncInterval: 1000,
+	enableJs: false,
 
 	inputTemplates: '',
 };

src/settings/SettingsTab.ts

@@ -103,6 +103,17 @@ export class MetaBindSettingTab extends PluginSettingTab {
 				});
 			});
 
+		new Setting(containerEl)
+			.setName('Enable JS Input Fields')
+			.setDesc("Enable the processing of JavaScript input fields. This is potentially DANGEROUS, thus it's disabled by default. RESTART REQUIRED.")
+			.addToggle(cb => {
+				cb.setValue(this.plugin.settings.enableJs);
+				cb.onChange(data => {
+					this.plugin.settings.enableJs = data;
+					this.plugin.saveSettings();
+				});
+			});
+
 		new Setting(containerEl)
 			.setName('Disable Code Block Restrictions')
 			.setDesc('Disable restrictions on which input fields can be created in which code blocks. Not recommended unless you know what you are doing.')