Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove alternative vapoursynth demuxer from ffmpeg #2771

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

LigH-de
Copy link
Contributor

@LigH-de LigH-de commented Sep 20, 2024

In a benchmark against the current multithreaded vapoursynth demuxer included in ffmpeg 7 and vspipe as external provider, the alternative demuxer was the slowest by far. Efforts to fix the patch being linkable again seem to have low priority, if any at all.

Fixes #2766

In a benchmark against the current multithreaded vapoursynth demuxer included in ffmpeg 7 and vspipe as external provider, the alternative demuxer was the slowest by far. Efforts to fix the patch being linkable again seem to have low priority, if any at all.
@L4cache
Copy link
Contributor

L4cache commented Sep 20, 2024

Maybe you can add the change you want in #2770 to this PR?

@LigH-de
Copy link
Contributor Author

LigH-de commented Sep 20, 2024

Unfortunately, neither do I know how to do these changes, nor do I know how to combine several patches into one common PR using the github UI.

@1480c1 1480c1 merged commit 00ef1d3 into m-ab-s:master Sep 20, 2024
@LigH-de LigH-de deleted the patch-1 branch September 20, 2024 16:44
@L4cache
Copy link
Contributor

L4cache commented Sep 22, 2024

You can continue to add commits to the branch (patch-1 in this case), after the PR is opened.

@LigH-de
Copy link
Contributor Author

LigH-de commented Sep 22, 2024

Anyway, I don't know how to implement #2770 - but I will keep your explanation in mind for any later efforts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ffmpeg fails linking vapoursynth: undefined reference to __imp_vsscript_* functions
3 participants