Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle relative links #1481

Closed
wants to merge 9 commits into from
Closed

Handle relative links #1481

wants to merge 9 commits into from

Conversation

mre
Copy link
Member

@mre mre commented Aug 7, 2024

WIP for #1296 and #1480

This just adds a failing test based on @nobkd's minimal repro.
I didn't fix the underlying issue.

@mre mre marked this pull request as draft August 7, 2024 20:39
@mre
Copy link
Member Author

mre commented Aug 7, 2024

It doesn't run the failing test yet. See #1483.
The Docker build failure is unrelated.

@nobkd
Copy link

nobkd commented Aug 13, 2024

Might also be interesting/relevant. Not sure if this is maybe already used by lychee. 🤷‍♂️
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/base

@mre
Copy link
Member Author

mre commented Oct 13, 2024

Might also be interesting/relevant. Not sure if this is maybe already used by lychee. 🤷‍♂️
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/base

Very interesting; I never heard of it.
The current implementation is pretty basic, and we don't use <base>. Looking at the docs, there seem to be quite a few different cases to be handled, so I'd like to postpone handling that for now. But thanks for the tip.

@mre
Copy link
Member Author

mre commented Oct 13, 2024

Superseded by #1489.

@mre mre closed this Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants