-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calibration rvc3 #1060
Calibration rvc3 #1060
Conversation
* Optimization and trace levels introduced WIP * tweaked parameters and updated tracelevel
* Make sure the same points are present on all images * Use initUndistortRectifyMap from fisheye calib
* if fisheye changed the requiement to need all the corners on the board * added coverage window * added charuco cornes and coverage visualization * small improvements * added marker visualization for capture * removed merge datasets * reprojection error and cover image * removed unused name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some fixes.
- depthai_helpers/calibration_utils_old.py remove this file
- remove the local board files and make sure the code to use depthai_boards submodule
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Please test calibration on OAK-D, OAK-D-W. and a PoE device before merging and check the visual depth quality before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added additional comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the trace level operation and don't introduce display_all.
Update on calibrate.py file.