add view.FindSidebar.activate method and stop writing code in view.Fi…

…ndSidebar.focus method
lutzroeder · Sep 19, 2024 · 0dc1d51 · 0dc1d51
1 parent cf7ed23
commit 0dc1d51
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/source/view.js b/source/view.js
@@ -3766,15 +3766,6 @@ view.FindSidebar = class extends view.Control {
     }
 
     focus(state) {
-        this._state = state || this._state;
-        this._query.focus();
-        this._query.value = '';
-        this._query.value = this._state.query;
-        for (const [name, toggle] of Object.entries(this._toggles)) {
-            toggle.checkbox.checked = this._state[name];
-            toggle.element.setAttribute('title', this._state[name] ? toggle.hide : toggle.show);
-        }
-        this._update();
     }
 
     _clear() {
@@ -4019,6 +4010,17 @@ view.FindSidebar = class extends view.Control {
         return [this._search, this._content];
     }
 
+    activate() {
+        this._query.focus();
+        this._query.value = '';
+        this._query.value = this._state.query;
+        for (const [name, toggle] of Object.entries(this._toggles)) {
+            toggle.checkbox.checked = this._state[name];
+            toggle.element.setAttribute('title', this._state[name] ? toggle.hide : toggle.show);
+        }
+        this._update();
+    }
+
     deactivate() {
         for (const element of this._focused) {
             this._blur(element);