Fixed Area Effect and Summoner Blocks crashing the game #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Cibernet83
commented
Sep 30, 2024
Cibernet83
commented
- Summoner Blocks and Area Effect Blocks no longer crash the game when right-clicked with a Spawn Egg and Potion respectively.
- Localized the set Entity Type and Potion Name for both blocks' status message.
- Added to changelog fix implemented by the packet cleanup, where in previous versions of the mod right-clicking a Summoner or Area Effect Block with their corresponding items wouldn't actually update their settings.
- Summoner Blocks and Area Effect Blocks no longer crash the game when right-clicked with a Spawn Egg and Potion respectively. - Localized the set Entity Type and Potion Name for both blocks' status message. - Added to changelog fix implemented by the packet cleanup, where in previous versions of the mod right-clicking a Summoner or Area Effect Block with their corresponding items wouldn't actually update their settings.
kirderf1
reviewed
Sep 30, 2024
kirderf1
reviewed
Sep 30, 2024
src/main/java/com/mraof/minestuck/block/redstone/SummonerBlock.java
Outdated
Show resolved
Hide resolved
….java Co-authored-by: kirderf1 <[email protected]>
kirderf1
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
@Dweblenod if you think that this needs testing, feel free to give it a look first. Otherwise, feel free to merge this immediately.
|
Just so you're aware, I tested my changes before making the PR, and it all seems to be working as intended! Further testing wouldn't hurt if necessary. |
Dweblenod
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.