Structure Block Registry Processor #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… block registry internally. In the middle of testing issues with any/all processors in the template pool of the testing structure
- Cleaned up code
Dweblenod
commented
Jun 30, 2024
src/main/resources/data/minestuck/worldgen/processor_list/structure_block_registry.json
Outdated
Show resolved
Hide resolved
Dweblenod
commented
Jun 30, 2024
src/main/java/com/mraof/minestuck/world/gen/feature/StructureBlockRegistryProcessor.java
Show resolved
Hide resolved
kirderf1
reviewed
Jun 30, 2024
src/main/java/com/mraof/minestuck/world/gen/feature/StructureBlockRegistryProcessor.java
Outdated
Show resolved
Hide resolved
- Made StructureBlockRegistryProcessor final
kirderf1
approved these changes
Jun 30, 2024
|
With everything else fine, the test structure ought to be removed. |
- Removed test structure
Removed the structure files but did keep the (unused) processor_list under the assumption it can be used in the near future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made changes to StructureBlockRegistryProcessor which allows StructureBlockRegistry to be called within finalizeProcess(). This makes it viable for use directly in a
template_pool, meaning the structure block registry is suitable for jigsaw structures!An example structure has been included for review purposes. It will need to be removed before merging.