-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plantable saplings, frost leaves drop saplings, tag changes to woods #615
Conversation
glubtier
commented
Apr 28, 2024
•
edited by kirderf1
Loading
edited by kirderf1
- Saplings were made pottable
- Frost leaves drop saplings and flowering frost leaves are available in creative tabs, as is the case with azalea/flowering azalea
- Corrected various wood-related tags, mostly aspect, to allow for crafting of certain items such as composters
- Modified Space aspect sapling texture
…BushBlock to Block
Frost Trees will now drop saplings Saplings are now pottable
src/main/java/com/mraof/minestuck/block/plant/MSPottedSaplings.java
Outdated
Show resolved
Hide resolved
Do you want this released in a small update on 1.20.1, or should this go in somewhere over on 1.20.4? |
1.20.1 would probably be better, it technically should have been part of the trees release. |
Snuck in a tiny little change to add wooden Slabs to the appropriate tags |
Looks like you accidentally deleted the entire "generated" folder in the last commit. |
oh gosh I did delete the generated folder for unrelated issues and regenerated, and it looks like it only pushed the delete. Hopefully this fixes it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tag changes ought to be referenced in the PR title/description. The space sapling texture change ought to be mentioned somewhere too.
src/main/java/com/mraof/minestuck/data/AspectTreeBlocksData.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mraof/minestuck/data/loot_table/MSBlockLootTables.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mraof/minestuck/data/loot_table/MSBlockLootTables.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mraof/minestuck/world/gen/feature/tree/EndTreeFeature.java
Outdated
Show resolved
Hide resolved
@kirderf1 I updated the PR. I included the space sapling there, but didn't add it to the change log... it was two pixels removed from each side so that it wouldn't stick out the sides of the pot. It felt a little cheeky to put it in the changelog lol. But I can if you think it's important! |
src/main/java/com/mraof/minestuck/data/AspectTreeBlocksData.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mraof/minestuck/data/loot_table/MSBlockLootTables.java
Outdated
Show resolved
Hide resolved
Looks like the texture was also moved vertically. If nothing else, I think that deserves to be added to the "Fixed" part of the changelog. |
Oh... uh, huh. I was working off my work folder, I guess I changed it but forgot to upload it before the 4/13 update lol. Sure I'll add that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright nice! Just one clarification for the changelog and this should be good by me.
Co-authored-by: kirderf1 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work! I do have a few comments.
- It looks like all the potted blocks should be added to the minecraft block tag "flower_pots"
- The base of the frost saplings stick out of the pot a little bit. Im fine with it staying as is but thought I would point it out.
ty, I can look at the tags later tonight, but until then do you have a screenshot of the frost sapling? I believe you, it just doesn't show that way on my screen. |
|