-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carapacian dialogue #598
Merged
Dweblenod
merged 7 commits into
lunar-sway:quest_systems
from
Dweblenod:quests/carapacian_dialogue
Apr 12, 2024
Merged
Carapacian dialogue #598
Dweblenod
merged 7 commits into
lunar-sway:quest_systems
from
Dweblenod:quests/carapacian_dialogue
Apr 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added 2 new Condition and some helper functions in Conditions - Added 2 new Trigger
- Added 1 new Condition and associated helper function
Dweblenod
commented
Apr 8, 2024
src/main/java/com/mraof/minestuck/data/dialogue/CarapacianSoldierDialogue.java
Outdated
Show resolved
Hide resolved
- Added 6 new dialogue - Added 1 new Condition and associated helper function
kirderf1
reviewed
Apr 8, 2024
…cian_dialogue # Conflicts: # CHANGELOG.md
kirderf1
reviewed
Apr 10, 2024
src/main/java/com/mraof/minestuck/data/dialogue/CarapacianSoldierDialogue.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mraof/minestuck/data/dialogue/CarapacianSoldierDialogue.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mraof/minestuck/data/dialogue/CarapacianSoldierDialogue.java
Outdated
Show resolved
Hide resolved
- Included exception catching for EQUIPMENT_CODEC
- Fixed explain_dreamers not following typical format - Made the visible Condition fail tooltip in barter be translatable
Existing comments should now be resolved! |
kirderf1
reviewed
Apr 12, 2024
src/main/java/com/mraof/minestuck/entity/carapacian/CarapacianEntity.java
Outdated
Show resolved
Hide resolved
kirderf1
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives pawns their own dialogue.
Relies on the already existing talking animation for Pawns created by Riotmode