Helper functions for common crafting recipes #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cruxite pressure plate
Dweblenod
approved these changes
Apr 6, 2024
There was a problem hiding this comment.
Now thats some good stuff : ) Its clear from the generated folder that there hasnt been too many changes while switching to these helper functions so I wont worry about testing it in game.
The only thing I could think of would be to add more templates to CommonRecipes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
CommonRecipeswith helper functions for creating common recipes during data-generation.The new helper functions are also being used where appropriate.
Cruxite recipes originally had raw cruxite as their unlock criteria, but not the actual block ingredient. For the recipes involved in this PR, I also added the block ingredient as an alternative unlock criteria.
I was originally thinking of going over additional recipes, like doors, trapdoors, fences and fence gates. But I decided to cut it short in order to focus on other things with 4/13 around the corner.