Dialogue edits and additions #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esponses) - Created new dialogues - Created new item tag for magic weapons and added a getter method for ItemRightClickEffect in WeaponItem - Added new constructor for GiveItem Trigger
- generic_thanks now has flag for if the player in the conversation is the one who helped the consort
|
There is still some more dialogue I would consider adding and I will need to fix the merge conflicts but Im going to start marking this as ready for review |
kirderf1
reviewed
Apr 4, 2024
# Conflicts: # CHANGELOG.md
… generic closing message used by it
- Expanded frog_creation dialogue - Changed the weights of 3 dialogue
- Added book_purpose dialogue
|
Added one more commit, and will consider this done if the new commit passes review! |
kirderf1
reviewed
Apr 7, 2024
...erated/resources/data/minestuck/minestuck/dialogue/consort/book_purpose/buy_my_products.json
Outdated
Show resolved
Hide resolved
kirderf1
reviewed
Apr 7, 2024
src/main/java/com/mraof/minestuck/data/dialogue/ConsortDialogue.java
Outdated
Show resolved
Hide resolved
kirderf1
approved these changes
Apr 10, 2024
|
I see you self-requested a review, did you intend to review it more or should I take your approval as an opportunity to merge? |
|
It's fine to merge by me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A review of existing dialogues and the creation of new ones.
Some changes that are notable:
All dialogue is written by Dweblenod