Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rung command #498

Merged
merged 13 commits into from
Nov 16, 2023
Merged

Conversation

GideonHead
Copy link
Contributor

No description provided.

Copy link
Member

@kirderf1 kirderf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned on discord, it'd be a good idea to combine this with the /setrung command to instead have /rung get and /rung set. You should also use a translation key for the success message.
Also, this command should require a gamemaster permission level.

@kirderf1
Copy link
Member

It has been a month since I last reviewed this. @GideonHead do you think that you might continue on this one anytime soon? And if not, would you be fine with letting someone else take over the development of this feature?

@kirderf1 kirderf1 added enhancement New feature or request stagnant Unlikely to see progress anytime soon labels Sep 30, 2023
@GideonHead
Copy link
Contributor Author

It has been a month since I last reviewed this. @GideonHead do you think that you might continue on this one anytime soon? And if not, would you be fine with letting someone else take over the development of this feature?

sorry I forgot about this for so long, I would be fine with someone else doing it.

@GideonHead
Copy link
Contributor Author

I forgot to change the name of the last commit, but all of the issues should now be solved.

@kirderf1 kirderf1 self-requested a review November 14, 2023 21:59
@kirderf1 kirderf1 removed the stagnant Unlikely to see progress anytime soon label Nov 14, 2023
@kirderf1 kirderf1 self-assigned this Nov 14, 2023
@kirderf1
Copy link
Member

@GideonHead Planning on making some last changes and pushing directly to the PR. Is that fine with you, or should I do it in a form where you look over those changes first?

@GideonHead
Copy link
Contributor Author

@GideonHead Planning on making some last changes and pushing directly to the PR. Is that fine with you, or should I do it in a form where you look over those changes first?

You can go ahead and do it, I dont mind.

@kirderf1 kirderf1 merged commit 9d214d9 into lunar-sway:1.20.1 Nov 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants