-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get rung command #498
get rung command #498
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned on discord, it'd be a good idea to combine this with the /setrung
command to instead have /rung get
and /rung set
. You should also use a translation key for the success message.
Also, this command should require a gamemaster permission level.
src/main/resources/assets/minestuck/animations/entity/underlings/giclops.animation.json
Outdated
Show resolved
Hide resolved
It has been a month since I last reviewed this. @GideonHead do you think that you might continue on this one anytime soon? And if not, would you be fine with letting someone else take over the development of this feature? |
sorry I forgot about this for so long, I would be fine with someone else doing it. |
remove cheese knife and combine get/setrung commands
I forgot to change the name of the last commit, but all of the issues should now be solved. |
@GideonHead Planning on making some last changes and pushing directly to the PR. Is that fine with you, or should I do it in a form where you look over those changes first? |
You can go ahead and do it, I dont mind. |
No description provided.