Always implement Default for Vec #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneiderfelipe
commented
Feb 23, 2024
soa-derive-internal/src/input.rs
Outdated
| @@ -116,6 +116,7 @@ impl Input { | |||
| match meta.path.get_ident() { | |||
| Some(ident) => { | |||
| assert!(ident != "Copy", "can not derive Copy for SoA vectors"); | |||
| assert!(ident != "Default", "Default is already derived for SoA vectors"); | |||
There was a problem hiding this comment.
This makes this PR a breaking change.
Luthaf
reviewed
Feb 24, 2024
This will silently ignore Default derive requests as well.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to always implement
DefaultforVec.This makes it behave more like
std::vec::Vec<T>, which implementsDefaultregardless ofT.