Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: lib: Export schema lib #110

Closed

Conversation

joaoantoniocardoso
Copy link

No description provided.

@patrickelectric
Copy link
Contributor

@joaoantoniocardoso can you rebase your PR for the CI ?

@DmitrySamoylov
Copy link
Contributor

Why do you want to re-export schema? The idea was to use it like so:

onvif = { git = "https://github.com/lumeohq/onvif-rs", rev = "92e0546" }
schema = { git = "https://github.com/lumeohq/onvif-rs", rev = "92e0546", default-features = false, features = ["devicemgmt", "media"] }

This way you don't build unnecessary parts of schema.

@joaoantoniocardoso
Copy link
Author

Why do you want to re-export schema? The idea was to use it like so:

onvif = { git = "https://github.com/lumeohq/onvif-rs", rev = "92e0546" }
schema = { git = "https://github.com/lumeohq/onvif-rs", rev = "92e0546", default-features = false, features = ["devicemgmt", "media"] }

This way you don't build unnecessary parts of schema.

Nice, this works for me, but I believe this should be noted in the README/FAQ, it is not obvious. If so, I recommend we add a name alias, because "schema" isn't the best name for a dependency in a larger repo.

onvif-schema = { git = "https://github.com/lumeohq/onvif-rs", rev = "92e0546", package = "schema", default-features = false, features = ["devicemgmt", "media"] }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants