added necessary fields for event pulling and an event example #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitrySamoylov
requested changes
Sep 26, 2023
|
Can you please rebase on |
ozdoganoguzhan
force-pushed
the
main
branch
4 times, most recently
from
f1b0d49
to
a2337ca
Compare
edited readme added event example revision + added SourceType test fix
ozdoganoguzhan
force-pushed
the
main
branch
from
bdd9fdd
to
dd67d98
Compare
|
hi, how is it going? |
|
The problem was in the test XML. I removed the envelope declarations and just left the responses and put the namespaces in them. Also moved the related tests to the end of tests file, to prevent conflict with the more recent commits to test file. |
This was fixed in |
|
Sorry for chipping in, also very interested in subscriptions & pull_messages. Really appreciate your work folks! |
|
Not sure if you receive notifications on failing CI jobs, but clippy is not happy now with some of the changes. |
|
everything should be ok now, thanks for your patience 😄 |
DmitrySamoylov
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type Changes: Added some fields that are required to create a subscription for pulling messages with a filter, and also for pulling messages from that subscription.
New Example: Added an example on how to pull messages periodically from a specific camera. Tested on Dahua.
Solves #107