Fix lint

onvif/src/discovery/mod.rs

@@ -1,7 +1,9 @@
 mod network_enumeration;
 
+use crate::discovery::network_enumeration::enumerate_network_v4;
 use futures_core::stream::Stream;
 use schema::ws_discovery::{probe, probe_matches};
+use std::iter::Iterator;
 use std::{
     collections::HashSet,
     fmt::{Debug, Formatter},
@@ -155,7 +157,7 @@ impl DiscoveryBuilder {
             futures::future::join_all(unicast_requests.iter().map(
                 |(sock, addr, device_sender, payload, message_id)| async move {
                     sock.send_to(payload, addr).await.ok()?;
-                    let (xml, _) = recv_string(&sock).await.ok()?;
+                    let (xml, _) = recv_string(sock).await.ok()?;
 
                     debug!("Probe match XML: {}", xml);
 
@@ -390,11 +392,6 @@ fn build_probe() -> probe::Envelope {
     }
 }
 
-use crate::discovery::network_enumeration::enumerate_network_v4;
-use std::iter::Iterator;
-use std::net::Ipv6Addr;
-use tokio_stream::StreamExt;
-
 #[tokio::test]
 async fn test_unicast() {
     let devices = DiscoveryBuilder::default()

onvif/src/discovery/network_enumeration.rs

@@ -4,7 +4,7 @@ use std::net::Ipv4Addr;
 fn octets_to_u32(octets: [u8; 4]) -> u32 {
     (octets[0] as u32) << (3 * 8)
         | (octets[1] as u32) << (2 * 8)
-        | (octets[2] as u32) << (1 * 8)
+        | (octets[2] as u32) << 8
         | (octets[3] as u32)
 }