LSP19 Social Registry #154

samuel-videau · 2023-01-01T19:27:26Z

@AntonioPMCS and myself are finally proposing the LIP we used in our Hackathon project LOOKSO.
It will probably need edits, but we decided to PR it, in order to progress on the subject.

Happy New Year! 🎉

frozeman · 2023-01-02T20:58:06Z

LSPs/LSP-19-Social-Registry.md

+        "hash": "Bytes32" // The hash of the post object
+      }
+    ], // The identifier (hash) of all the posts this account has liked,
+    "dislikes": [


Facebook consciously decided against dislikes. It would be good to look into that reasoning before adding this here.

We also did not use it in our Lookso project, as we don't find it relevant. However, we thought it might be important proposing a really complete and flexible standard, in order for people to be able to build any kind of social app they want on top of that. For instance, it might be relevant for people doing a Youtube or Reddit like DApp

frozeman · 2023-01-02T21:00:58Z

Amazing. Thanks for that. I’ll comment on the structure once I had the time to have a proper look at it.

frozeman · 2023-01-24T08:52:43Z

I think messages should contain a signature, even with the issue, that the signing key might not be present anymore at the UP in some point in the future, but there are use cases where signing a message is the only way (maybe no validator was used, for example)

samuel-videau · 2023-01-31T06:02:20Z

I think messages should contain a signature, even with the issue, that the signing key might not be present anymore at the UP in some point in the future, but there are use cases where signing a message is the only way (maybe no validator was used, for example)

Yes indeed, we took it out of our flow as we think it's not useful in our case. But it would be indeed good adding it to the standard. I'll commit it

samuel-videau · 2023-04-13T04:59:02Z

@frozeman the LSP19ProfilePostSignature has been added back, as well as a couple of small improvements

CJ42

@samuel-videau very great proposals! I remember it from the Hackathon indeed!

I have added some review comments :)

CJ42 · 2023-07-04T09:43:10Z

LSPs/LSP-19-Social-Registry.md

+
+## Abstract
+
+This standard defines a set of data formats and a key-value pair to create a Social Media Feed, combining [ERC725Account](https://github.com/lukso-network/LIPs/blob/main/LSPs/LSP-0-ERC725Account.md) and an open distributed storage network such as [IPFS](https://ipfs.tech/) or [ARWEAVE](https://arweave.org).


Maybe?

Suggested change

This standard defines a set of data formats and a key-value pair to create a Social Media Feed, combining [ERC725Account](https://github.com/lukso-network/LIPs/blob/main/LSPs/LSP-0-ERC725Account.md) and an open distributed storage network such as [IPFS](https://ipfs.tech/) or [ARWEAVE](https://arweave.org).

This standard defines a set of data formats and a key-value pair to create a decentralised Social Media Feed, combining [LSP0-ERC725Account](https://github.com/lukso-network/LIPs/blob/main/LSPs/LSP-0-ERC725Account.md) and an open distributed storage network such as [IPFS](https://ipfs.tech/) or [ARWEAVE](https://arweave.org).

CJ42 · 2023-07-04T09:43:26Z

LSPs/LSP-19-Social-Registry.md

+## Abstract
+
+This standard defines a set of data formats and a key-value pair to create a Social Media Feed, combining [ERC725Account](https://github.com/lukso-network/LIPs/blob/main/LSPs/LSP-0-ERC725Account.md) and an open distributed storage network such as [IPFS](https://ipfs.tech/) or [ARWEAVE](https://arweave.org).
+It also defines a smart contract used to guaranty authenticity and timestamp of a post.


Suggested change

It also defines a smart contract used to guaranty authenticity and timestamp of a post.

It also defines a smart contract that can be used to guaranty authenticity and timestamp of a post.

CJ42 · 2023-07-04T09:44:17Z

LSPs/LSP-19-Social-Registry.md

+This standard defines a set of data formats and a key-value pair to create a Social Media Feed, combining [ERC725Account](https://github.com/lukso-network/LIPs/blob/main/LSPs/LSP-0-ERC725Account.md) and an open distributed storage network such as [IPFS](https://ipfs.tech/) or [ARWEAVE](https://arweave.org).
+It also defines a smart contract used to guaranty authenticity and timestamp of a post.
+
+## Motivation


Super the motivation section 👌 Very on point!

CJ42 · 2023-07-04T09:45:49Z

LSPs/LSP-19-Social-Registry.md

+
+### LSP19SocialRegistry
+
+A Universal Profile's Social Media State will live under a record referenced by the "LSP19SocialRegistry" data key of their ERC725Y store.


Maybe we can keep it generic here? As Universal Profile could be one of the type of contracts that use it, but we don't know yet which other type of contracts could use it.

Suggested change

A Universal Profile's Social Media State will live under a record referenced by the "LSP19SocialRegistry" data key of their ERC725Y store.

A Social Media State (for instance the one of a Universal Profile) will live under a record referenced by the "LSP19SocialRegistry" data key of their ERC725Y store.

CJ42 · 2023-07-04T09:47:22Z

LSPs/LSP-19-Social-Registry.md

+  }
+```
+
+This registry should be updated everytime a new post is added by the user.


Let's ensure the standard verbs are in uppercase.

Suggested change

This registry should be updated everytime a new post is added by the user.

This registry SHOULD be updated everytime a new post is added by the user.

CJ42 · 2023-07-04T09:51:46Z

LSPs/LSP-19-Social-Registry.md

+A Profile Post can be an original message, a comment on another post or a repost. The JSON file should have the following format:
+
+Not all fields are required. For example, a `repost` doesn't need a message, but it should have the `url` and `hash` to the original post.
+The `LSP19ProfilePostSignature` property is optional and depends on the use case. It is used to authenticate a post through a controller EOA (Externally Owned Account)


Does it has to be an EOA? Can't it be another 🆙 ? 😉

Suggested change

The `LSP19ProfilePostSignature` property is optional and depends on the use case. It is used to authenticate a post through a controller EOA (Externally Owned Account)

The `LSP19ProfilePostSignature` property is OPTIONAL and depends on the use case. It is used to authenticate a post through a controller EOA (Externally Owned Account)

Hmm what do you mean ?

CJ42 · 2023-07-04T09:52:40Z

LSPs/LSP-19-Social-Registry.md

+  "LSP19ProfilePost": {
+    "version": "0.0.1", // The Metadata version of this post
+    "author": "Address", // The Universal Profile who authored the post
+    "locale": "string", // language code - Country Code (de_DE)


Might be good to be consistent. Above, strings are mentioned as String (uppercase S).

CJ42 · 2023-07-04T09:54:48Z

LSPs/LSP-19-Social-Registry.md

+      }
+    ],
+    "assets": [
+      "interface": "string" // Contract interface


Maybe here you could provide the option to be either:

a contract interface name (e.g: ILSPN...)

or a bytes4 interface identifier (e.g: 0x3e89ad98 for LSP0 interface).

Suggested change

"interface": "string" // Contract interface

"interface": "string | bytes4" // Contract interface

Actually it might maybe be good having both

CJ42 · 2023-07-04T09:55:30Z

LSPs/LSP-19-Social-Registry.md

+```js
+{
+  "LSP19ProfilePost": {
+    "version": "0.0.1", // The Metadata version of this post


Might be good to add a sentence in the standard to describe this field.

CJ42 · 2023-07-04T09:58:57Z

LSPs/LSP-19-Social-Registry.md

+* @notice A validator tailored for Universal Profiles and content publishing
+* @dev Writes to the Universal Profile key/value store
+*/
+contract LSP19PostValidator is Context {


Is there a standard interface for the contract (some standard functions), or it could be implemented in any way.

I am asking as the title says:

And from my understanding, I thought it would also include an interface (set of functions).

Hmm ideally, there would be only one of this contract deployed, that everybody would use, it actually doesn t really make sense having multiple instances of this contract deployed, apart making the verification process a bit harder.

frozeman · 2023-10-19T12:56:35Z

We will revisit that later. This will be relevant for droops and universalprofile.cloud.
Its a good start for a conversation.

samuel-videau · 2023-10-20T04:53:23Z

We will revisit that later. This will be relevant for droops and universalprofile.cloud. Its a good start for a conversation.

Sounds good! We also need to dive back in, can be a good topic discussion in Istanbul :)

frozeman reviewed Jan 2, 2023

View reviewed changes

feat: LSP19 Social Registry

3048a0e

samuel-videau force-pushed the feat/LSP19_Social_Registry branch from c6bd51a to 3048a0e Compare April 13, 2023 04:56

CJ42 reviewed Jul 4, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LSP19 Social Registry #154

LSP19 Social Registry #154

samuel-videau commented Jan 1, 2023

frozeman Jan 2, 2023

samuel-videau Jan 2, 2023

frozeman commented Jan 2, 2023

frozeman commented Jan 24, 2023

samuel-videau commented Jan 31, 2023

samuel-videau commented Apr 13, 2023 •

edited

Loading

CJ42 left a comment

CJ42 Jul 4, 2023

CJ42 Jul 4, 2023

CJ42 Jul 4, 2023

CJ42 Jul 4, 2023

CJ42 Jul 4, 2023

CJ42 Jul 4, 2023

samuel-videau Jul 4, 2023

CJ42 Jul 4, 2023

CJ42 Jul 4, 2023

samuel-videau Jul 4, 2023

CJ42 Jul 4, 2023

CJ42 Jul 4, 2023

samuel-videau Jul 4, 2023

frozeman commented Oct 19, 2023

samuel-videau commented Oct 20, 2023


		## Abstract

		This standard defines a set of data formats and a key-value pair to create a Social Media Feed, combining [ERC725Account](https://github.com/lukso-network/LIPs/blob/main/LSPs/LSP-0-ERC725Account.md) and an open distributed storage network such as [IPFS](https://ipfs.tech/) or [ARWEAVE](https://arweave.org).

	It also defines a smart contract used to guaranty authenticity and timestamp of a post.
	It also defines a smart contract that can be used to guaranty authenticity and timestamp of a post.


		### LSP19SocialRegistry

		A Universal Profile's Social Media State will live under a record referenced by the "LSP19SocialRegistry" data key of their ERC725Y store.

	A Universal Profile's Social Media State will live under a record referenced by the "LSP19SocialRegistry" data key of their ERC725Y store.
	A Social Media State (for instance the one of a Universal Profile) will live under a record referenced by the "LSP19SocialRegistry" data key of their ERC725Y store.

	This registry should be updated everytime a new post is added by the user.
	This registry SHOULD be updated everytime a new post is added by the user.

	The `LSP19ProfilePostSignature` property is optional and depends on the use case. It is used to authenticate a post through a controller EOA (Externally Owned Account)
	The `LSP19ProfilePostSignature` property is OPTIONAL and depends on the use case. It is used to authenticate a post through a controller EOA (Externally Owned Account)

	"interface": "string" // Contract interface
	"interface": "string \| bytes4" // Contract interface

LSP19 Social Registry #154

Are you sure you want to change the base?

LSP19 Social Registry #154

Conversation

samuel-videau commented Jan 1, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

frozeman commented Jan 2, 2023

frozeman commented Jan 24, 2023

samuel-videau commented Jan 31, 2023

samuel-videau commented Apr 13, 2023 • edited Loading

CJ42 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

frozeman commented Oct 19, 2023

samuel-videau commented Oct 20, 2023

samuel-videau commented Apr 13, 2023 •

edited

Loading