Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix *potential* typo #180

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

dotfrankruan
Copy link

In Listmonk, it should be called 'UUID' instead of 'UIID'. Just to avoid confusions.

@lukeorth
Copy link
Owner

lukeorth commented Aug 7, 2024

Thank you, @dotfrankruan. This was definitely a misspelling on my part. 😬

My only concern with merging the PR is backwards compatibility... The README changes are great, but the code needs to work for both the old .Site.Params.listmonk_subscription_list_uiid and the new .Site.Params.listmonk_subscription_list_uuid. The reason being: users may pull the latest theme updates, not know that their site params needed to change, and have Listmonk suddenly break.

If you can add that in, I'll get this merged. Otherwise I'll try looking into it shortly.

I appreciate your work! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants