Added support for several mods #207

vizthex123 · 2024-05-24T03:45:56Z

Bigger Reactors (also renamed the file for Extreme Reactors to make it clearer)
Deeper Caves
Deep Resonance
Galosphere (added Salt Blocks since Silver Ore was already done)
The Outer End
Project Red
Regions Unexplored
RF Tools
Thermal Series
XyCraft: World (only Kivi and Aluminum since Xychorium ores don't copy over textures)
Yung's Cave Biomes

- Bigger Reactors (also renamed the file for Extreme Reactors to make it clearer) - Deeper Caves - Deep Resonance - Galosphere (added Salt Blocks since Silver Ore was already done) - The Outer End - Regions Unexplored - RF Tools - Thermal Series - XyCraft: World (only Kivi and Aluminum since Xychorium ores don't copy over textures)

vizthex123 · 2024-05-24T03:49:28Z

I'm hoping the mod dev can figure out why Xychorium variants don't have textures (mentioned it #205). I think it uses a custom shader or something that Dynamic Asset Generator isn't properly detecting.

I tested it and it seems like it does, but at this point I don't even know anymore.

lukebemish · 2024-05-24T06:18:39Z

I'll look into the missing textures; I suspect you're write, they probably have some sort of custom model thingy I can't detect. I'll try to review the rest of this PR when I have a chance, though 1.20.1 is fairly low priority right now so it may be a bit.

vizthex123 · 2024-05-24T07:47:32Z

Alright, that sounds good.

Just wanted to toss in what I'd done to save you some time (I figured it probably wasn't too hard to release an update for 1.20.1 if code wasn't changed) and support a couple major-ish mods that were missing it.

Added `_ore` to each ID and `orename` to a few that were missing it.

Also blacklisted Kivi Aluminum again since I misunderstood how that worked. I still can't get Slate to blacklist vanilla ores ffs

lukebemish · 2024-05-30T01:20:15Z

Sorry I've been so delayed in looking at this! I should have more free time soon so I'll plan on getting it looked over and merged soon-ish.

vizthex123 · 2024-05-30T21:54:42Z

noice, thanks.

If you're able to check why it's making Slate variations of vanilla ores when Deeper Caves is installed it'd be nice. The mod adds them already, and I tried to blacklist the default ores but it's not working for me - finally fixed that in bd4d1cb

If you could check on Xychorium ores not having textures it'd be great. I can open another PR to add them, or add them to this one before it gets merged.

I had an epiphany to just not assign a type to them lol

I really should've triple-checked all of this before forking the repo cuz now i've got a dozen useless commits lol

.../resources/defaultresources/excavated_variants/excavated_variants/variants/deepercaves.json5

...in/resources/defaultresources/excavated_variants/excavated_variants/variants/minecraft.json5

.../resources/defaultresources/excavated_variants/excavated_variants/variants/deepercaves.json5

...n/resources/defaultresources/excavated_variants/excavated_variants/variants/galosphere.json5

...in/resources/defaultresources/excavated_variants/excavated_variants/variants/outer_end.json5

...ces/defaultresources/excavated_variants/excavated_variants/variants/regions_unexplored.json5

...main/resources/defaultresources/excavated_variants/excavated_variants/variants/xycraft.json5

...esources/defaultresources/excavated_variants/excavated_variants/variants/deepresonance.json5

lukebemish · 2024-07-13T01:40:41Z

Once the remaining feedback is addressed I'll get this merged. I can handle porting it forward to newer versions myself; that shouldn't be too bad. Thank you a bunch for contributing!

vizthex123 · 2024-07-14T22:14:38Z

Got everything resolved, and yeah I don't mind. If I ever find more mods missing support, I'll open another PR.

If you could check on Xychorium and add it in an update alongside this PR it'd be amazing. Would love to give all XyCraft ores support for this mod.

lukebemish

Still need to fix whatever bunch of random changes happened to that one file...

vizthex123 · 2024-07-15T05:42:32Z

re-downloaded it off the github.

Apparently I re-organized the file to make it more readable when making the new files I added.

lukebemish · 2024-07-15T05:59:49Z

Looks good to me; I'll get it merged when I've got some free time

vizthex123 · 2024-07-15T23:17:57Z

Alrighty.

I'll add support for Project Red too.

lukebemish · 2024-07-15T23:23:14Z

Please do not modify this PR further before I merge it. I'll have to review any modifications you make and that'll set it back. Don't feel bad about splitting stuff into separate PRs

Can't believe I forgot such a classic mod lol

vizthex123 · 2024-07-15T23:43:04Z

Sorry, already did that before you commented (or at least before I saw you left a comment). Still not used to making a ton of small commits & whatnot (complete opposite of how I do things lol, and I really hate having to make a ton of tiny changes).

I'll keep it in mind for next time though.

I'm annoyed I have to make another damn commit for this. Can't believe I forgot to double-check it ;-;

...n/resources/defaultresources/excavated_variants/excavated_variants/variants/projectred.json5

lukebemish

Looks good. I'll get it out in the next release -- may be just a bit as I have to get all the stuff for that older version working again and port stuff forwards before the release.

vizthex123 · 2024-08-11T20:02:49Z

noice, thanks. Looking forward to it.

lukebemish · 2024-10-06T06:24:26Z

That last commit was (intentionally) reverted and not included when I merged the PR -- if you want to submit it, it should be a separate PR (in fact compat for different mods should be in general) -- adding more stuff after a PR is approved just means that it has to go through the approval process again. The other changes will be released for 1.20.1 as soon as I've got it ported to newer versions (1.21.x) as well.

vizthex123 · 2024-10-06T21:55:19Z

yeah, i couldn't figure out how to open another one when one was already open (i'm really dumb and only use github for backups lol).

but i'll see if i can do it now.

thanks for merging it.

vizthex123 added 4 commits May 23, 2024 22:54

Fixed Galosphere's salt being a custom type

0eed4f8

Removed custom type for Chalk

ccfb89a

Fixed Slate and Kivi Ores not auto-generating

f4ebe21

Pretty sure this fixes Kivi Ores

6eae4bc

I tested it and it seems like it does, but at this point I don't even know anymore.

vizthex123 added 2 commits May 29, 2024 16:15

Updated the mod support I added

710e397

Added `_ore` to each ID and `orename` to a few that were missing it.

Fixed Aluminum ID and Slate type

838baa5

Also blacklisted Kivi Aluminum again since I misunderstood how that worked. I still can't get Slate to blacklist vanilla ores ffs

vizthex123 added 4 commits June 2, 2024 23:49

Fixed the name for TE's Silver

2eedcf6

Standardized a few ore names I missed

ace0fe7

Finally fixed all the duplicate slate ores

690d432

I had an epiphany to just not assign a type to them lol

Fixed incorrect localized name for lapis

8f56fe3

I really should've triple-checked all of this before forking the repo cuz now i've got a dozen useless commits lol

lukebemish requested changes Jul 5, 2024

View reviewed changes

Prefixed stone IDs

65025b9

lukebemish requested changes Jul 13, 2024

View reviewed changes

...esources/defaultresources/excavated_variants/excavated_variants/variants/deepresonance.json5 Show resolved Hide resolved

Finally fixed the Slate duplication issue I've been havnig

bd4d1cb

vizthex123 requested a review from lukebemish July 14, 2024 22:14

lukebemish requested changes Jul 15, 2024

View reviewed changes

Re-downloaded the minecraft.json off of the GitHub

f9a8ee8

Apparently I re-organized the file to make it more readable when making the new files I added.

lukebemish approved these changes Jul 15, 2024

View reviewed changes

Added support for Project Red

f3be60c

Can't believe I forgot such a classic mod lol

Fixed Electrotine not being registered

4673b7b

I'm annoyed I have to make another damn commit for this. Can't believe I forgot to double-check it ;-;

lukebemish requested changes Jul 16, 2024

View reviewed changes

...n/resources/defaultresources/excavated_variants/excavated_variants/variants/projectred.json5 Outdated Show resolved Hide resolved

vizthex123 requested a review from lukebemish August 4, 2024 04:07

lukebemish approved these changes Aug 4, 2024

View reviewed changes

Added support for Yung's Cave Biomes

1a9350b

lukebemish merged commit 1a9350b into lukebemishprojects:1.20.1 Oct 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added support for several mods #207

Added support for several mods #207

vizthex123 commented May 24, 2024 •

edited

Loading

vizthex123 commented May 24, 2024

lukebemish commented May 24, 2024

vizthex123 commented May 24, 2024

lukebemish commented May 30, 2024

vizthex123 commented May 30, 2024 •

edited

Loading

lukebemish commented Jul 13, 2024 •

edited

Loading

vizthex123 commented Jul 14, 2024

lukebemish left a comment

vizthex123 commented Jul 15, 2024 •

edited

Loading

lukebemish commented Jul 15, 2024

vizthex123 commented Jul 15, 2024

lukebemish commented Jul 15, 2024

vizthex123 commented Jul 15, 2024 •

edited

Loading

lukebemish left a comment

vizthex123 commented Aug 11, 2024

lukebemish commented Oct 6, 2024

vizthex123 commented Oct 6, 2024

Added support for several mods #207

Added support for several mods #207

Conversation

vizthex123 commented May 24, 2024 • edited Loading

vizthex123 commented May 24, 2024

lukebemish commented May 24, 2024

vizthex123 commented May 24, 2024

lukebemish commented May 30, 2024

vizthex123 commented May 30, 2024 • edited Loading

lukebemish commented Jul 13, 2024 • edited Loading

vizthex123 commented Jul 14, 2024

lukebemish left a comment

Choose a reason for hiding this comment

vizthex123 commented Jul 15, 2024 • edited Loading

lukebemish commented Jul 15, 2024

vizthex123 commented Jul 15, 2024

lukebemish commented Jul 15, 2024

vizthex123 commented Jul 15, 2024 • edited Loading

lukebemish left a comment

Choose a reason for hiding this comment

vizthex123 commented Aug 11, 2024

lukebemish commented Oct 6, 2024

vizthex123 commented Oct 6, 2024

vizthex123 commented May 24, 2024 •

edited

Loading

vizthex123 commented May 30, 2024 •

edited

Loading

lukebemish commented Jul 13, 2024 •

edited

Loading

vizthex123 commented Jul 15, 2024 •

edited

Loading

vizthex123 commented Jul 15, 2024 •

edited

Loading