Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat[serializers]: specify default JSON encoders to make subclassing more easily #42

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat[serializers]: specify default JSON encoders to make subclassing more easily #42

wants to merge 2 commits into from

Conversation

spaceone
Copy link
Contributor

@spaceone spaceone commented Nov 3, 2021 •
edited
Loading

  • feat[serializers]: specify default JSON encoders
    → make subclassing more easily

  • feat[serializers]: specify empty __slots__ for serializer classes

  • → a little bit gain of memory usage for multiple instances

cassiobotaro
cassiobotaro suggested changes Nov 3, 2021
View reviewed changes
Copy link
Member

@cassiobotaro cassiobotaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write tests?

@spaceone
Copy link
Contributor Author

spaceone commented Nov 3, 2021 •
edited
Loading

Can you write tests?

Hm, what should be tested here?
There are tests for the JSON serializer to work.
There isn't any real behavior change.

@spaceone
Copy link
Contributor Author

spaceone commented Nov 4, 2021

@cassiobotaro FYI: rebased onto latest changes.
What about: #42 (comment)

@cassiobotaro
Copy link
Member

@spaceone You are right about the tests, What about updating the JSON example on README too?

@spaceone
Copy link
Contributor Author

spaceone commented Nov 6, 2021 •
edited
Loading

@spaceone You are right about the tests, What about updating the JSON example on README too?

Ok, I adjusted this as well. But I don't think it must be identical to the implementation. Otherwise the README could just link to the source code.

@spaceone spaceone mentioned this pull request Dec 9, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cassiobotaro cassiobotaro cassiobotaro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spaceone @cassiobotaro