Exclude getdaft on Windows #3629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results 4 files ±0 4 suites ±0 34m 9s ⏱️ + 4m 11s Results for commit 46783c2. ± Comparison against base commit 42723e3. This pull request skips 2 tests. |
justinxzhao
approved these changes
Sep 18, 2023
|
Landing this for now to unblock until Eventual-Inc/Daft#235 lands. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Daft requirement renders Windows install near impossible. Wheels are not available and build needs to have Strawberry Perl + Rust\Cargo and to be able to compile OpenSSL from source (and I've not been able to successfully do so).
Can we consider not requiring getdaft when in a Windows environment, to enable to use Ludwig, at least until wheels are available? (ref: Eventual-Inc/Daft#235)
With this PR, Ludwig installs fine on Python 3.9 on Windows, and I am able to perform a titanic training