Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary mockdata parameters #1126

Merged
merged 17 commits into from
Oct 1, 2024

Conversation

michplunkett
Copy link
Collaborator

@michplunkett michplunkett commented Sep 30, 2024

Fixes issue

#1125

Description of Changes

Removed the mockdata parameter from test functions that don't require it.

Tests and Linting

  • This branch is up-to-date with the develop branch.
  • pytest passes on my local development environment.
  • pre-commit passes on my local development environment.

@michplunkett michplunkett self-assigned this Sep 30, 2024
@michplunkett michplunkett linked an issue Sep 30, 2024 that may be closed by this pull request
@michplunkett michplunkett changed the title Remove unnecessary test parameters Remove unnecessary mockdata parameters Sep 30, 2024
@michplunkett michplunkett marked this pull request as ready for review September 30, 2024 03:58
Copy link
Collaborator

@abandoned-prototype abandoned-prototype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might also want to remove these lines:

@pytest.fixture
def mockdata(session):
pass

@michplunkett
Copy link
Collaborator Author

michplunkett commented Oct 1, 2024

@abandoned-prototype, we still use mockdata in other tests throughout various files (test_descriptions.py, test_image_tagging.py, test_functional, test_models, etc.) and , so we can't get rid of it quite yet. To remove those lines, we'd need to do some general test restructuring that would go beyond this simple pruning.

@michplunkett michplunkett merged commit 710019e into develop Oct 1, 2024
3 checks passed
@michplunkett michplunkett deleted the remove-unnecessary-test-params branch October 1, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused parameters in test functions
2 participants