Remove Bootstrap3 #1123
Merged
Remove Bootstrap3 #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing unused boostrap3 files
Removing unused boostrap3 files
Removing unused boostrap3 files
Removing unused boostrap3 files
Removing unused boostrap3 files
Removing unused boostrap3 files
Removing unused boostrap3 files
Removing unused boostrap3 files
sea-kelp
force-pushed
the
bootstrap3-deprecation
branch
from
eb97b56
to
de26eb1
Compare
sea-kelp
approved these changes
Sep 6, 2024
michplunkett
reviewed
Sep 7, 2024
| @@ -31,10 +31,6 @@ create_db: start | |||
| ## Creating database | |||
| docker compose run --rm web alembic --config=./OpenOversight/migrations/alembic.ini stamp head | |||
|
|
|||
| .PHONY: assets | |||
michplunkett
reviewed
Sep 7, 2024
Comment on lines
-15
to
-18
| # install node | ||
| ENV NODE_SETUP_SHA=5d07994f59e3edc2904c547e772b818d10abb066f6ff36ab3db5d686b0fe9a73 | ||
| RUN curl ${CURL_FLAGS} \ | ||
| https://raw.githubusercontent.com/nodesource/distributions/b8510857fb4ce4b023161be8490b00119884974c/deb/setup_12.x |
There was a problem hiding this comment.
I'm so happy to see this removed.
michplunkett
approved these changes
Sep 7, 2024
sea-kelp
added a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Sep 9, 2024
Migrates off bootstrap3 and into bootstrap5. Thank you @psjalltheway !!! Removes deprecated files which are causing conflicts for the new HTML/CSS which will come in a separate PR. - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment. --------- Co-authored-by: psjalltheway <[email protected]> Co-authored-by: sea-kelp <[email protected]>
3 tasks
AetherUnbound
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Oct 28, 2024
Migrates off bootstrap3 and into bootstrap5. Thank you @psjalltheway !!! Removes deprecated files which are causing conflicts for the new HTML/CSS which will come in a separate PR. - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment. --------- Co-authored-by: Freddy Martinez <[email protected]> Co-authored-by: psjalltheway <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue
Migrates off bootstrap3 and into bootstrap5. Thank you @psjalltheway !!!
Description of Changes
Removes deprecated files which are causing conflicts for the new HTML/CSS which will come in a separate PR.
Notes for Deployment
Screenshots (if appropriate)
Tests and Linting
developbranch.pytestpasses on my local development environment.pre-commitpasses on my local development environment.