Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Date response header. #1866

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Adds Date response header. #1866

merged 1 commit into from
Apr 16, 2024

Conversation

jwoertink
Copy link
Member

Purpose

Fixes #1863

Description

Apparently all servers should respond with a Date header. Kemal just added it in, so why not? 😄

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

robacarp
robacarp approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@robacarp robacarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌴

@jwoertink jwoertink merged commit b72da95 into main Apr 16, 2024
5 checks passed
@jwoertink jwoertink deleted the issues/1863 branch April 16, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robacarp robacarp robacarp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Date header to responses
2 participants
@jwoertink @robacarp