Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): added bangladeshi-taka icon #2416

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mayeenulislam
Copy link

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

Adding a new icon: "Bangladeshi Taka"

  • BDT
  • ISO 4217
  • Unicode: U+09F3

Icon use case

A real-life currency — also used as Money, Shopping, Discount

Alternative icon designs

No alternative icon designs. It's the universal "Taka" icon

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons: indian-rupee, badge-indian-rupee, receipt-indian-rupee
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

- BDT
- ৳
- ISO 4217
- Unicode: U+09F3
@github-actions github-actions bot added 🎨 icon About new icons ⚛️ react native package About the React Native package 🫧 metadata Improved metadata labels Aug 29, 2024
Copy link

github-actions bot commented Aug 29, 2024

Added or changed icons

icons/badge-bangladeshi-taka.svgicons/bangladeshi-taka.svgicons/receipt-bangladeshi-taka.svg

Preview cohesion icons/square-minus.svgicons/square-chevron-down.svgicons/square-x.svg
icons/badge-bangladeshi-taka.svgicons/bangladeshi-taka.svgicons/receipt-bangladeshi-taka.svg
icons/utensils.svgicons/circle-arrow-down.svgicons/user-search.svg
Preview stroke widths icons/badge-bangladeshi-taka.svgicons/bangladeshi-taka.svgicons/receipt-bangladeshi-taka.svg
icons/badge-bangladeshi-taka.svgicons/bangladeshi-taka.svgicons/receipt-bangladeshi-taka.svg
icons/badge-bangladeshi-taka.svgicons/bangladeshi-taka.svgicons/receipt-bangladeshi-taka.svg
DPI Preview (24px) icons/badge-bangladeshi-taka.svg icons/bangladeshi-taka.svg icons/receipt-bangladeshi-taka.svg
Icon X-rays icons/badge-bangladeshi-taka.svg icons/bangladeshi-taka.svg icons/receipt-bangladeshi-taka.svg
Icon Diffs

icons/badge-bangladeshi-taka.svg

icons/bangladeshi-taka.svg

icons/receipt-bangladeshi-taka.svg

Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const BadgeBangladeshiTakaIcon = createLucideIcon('BadgeBangladeshiTaka', [
  ["path",{"stroke-width":"1.5","d":"M8.92 7.83c1.83-.25 1.69 1.04 1.66 3.67v3.79c-.05 1.44 2.08 2.11 3.52 1.12.92-.64.87-1.63.54-2.14M9 11h6"}],
  ["path",{"stroke-width":"1.5","d":"M3.85 8.62a4 4 0 0 1 4.78-4.77 4 4 0 0 1 6.74 0 4 4 0 0 1 4.78 4.78 4 4 0 0 1 0 6.74 4 4 0 0 1-4.77 4.78 4 4 0 0 1-6.75 0 4 4 0 0 1-4.78-4.77 4 4 0 0 1 0-6.76Z"}]
])

const BangladeshiTakaIcon = createLucideIcon('BangladeshiTaka', [
  ["path",{"stroke-width":"1.5","d":"M7 4.16C10.48 3.17 9.89 6.94 9.93 10.88V18.24C9.96 21.14 13.79 21.82 16.46 19.98C18.77 18.37 18.42 15.63 15.83 15.57M7 10H14"}]
])

const ReceiptBangladeshiTakaIcon = createLucideIcon('ReceiptBangladeshiTaka', [
  ["path",{"stroke-width":"1.5","d":"M4 2v20l2-1 2 1 2-1 2 1 2-1 2 1 2-1 2 1V2l-2 1-2-1-2 1-2-1-2 1-2-1-2 1-2-1Z"}],
  ["path",{"stroke-width":"1.5","d":"M9 7.88c1.88-.54 1.56 1.5 1.58 3.62V15.47c.01 1.56 2.08 1.93 3.52.94 1.25-.87 1.06-2.35-.34-2.38M9 11h3.72"}]
])

@mayeenulislam mayeenulislam changed the title New Icon: Bangladeshi Taka (৳) feat(icons): added bangladeshi-taka icon Aug 29, 2024
@karsa-mistmere
Copy link
Member

Hi @mayeenulislam,

I'm afraid these have several guideline violations, please make sure to more closely follow our icon design guidelines.

The main issues that need to be addressed:

  • Not all elements have 2px gaps between them (especially for the receipt and badge versions), see guideline no. 8
    (Not sure, if this makes the small versions feasible or not)
  • The icons do not stick to the grid, leading to blurry lines, see our DPI preview and guideline no. 13
  • There are some really uneven curves, can we maybe try a more geometric approach? (guideline no. 12)

More Lucide-ey proposas, based on Google image search (but I'm totally unsure if they're recognisable or good enough):

icons
Open lucide studio

icons
Open lucide studio

icons
Open lucide studio

@jguddas
Copy link
Member

jguddas commented Sep 1, 2024

We should maybe rethink the currency icons, we basically have the same issues here as we do with the brand icons where we try to shoehorn existing possibly copyrighted work into our design guidelines.

For example :
The European Community, represented by the European Commission, owns the copyright for the euro symbol.

@mayeenulislam
Copy link
Author

mayeenulislam commented Sep 2, 2024

@karsa-mistmere I've revised the design, as far as I understood your design guidelines and the previous icons that you already have merged. I did not find any dedicated pull request on "Indian Rupee" (except #1401), and I could not measure the deviations.
With these changes, the stroke widths improved.

BTW, about the DPI (24px) I checked the Rupee symbols in Figma and the symbols that I designed. In the 1px grid, they completely matched in many ways.

Given my current understanding, I believe these modifications will align the design with the guidelines.

@karsa-mistmere
Copy link
Member

@karsa-mistmere I've revised the design, as far as I understood your design guidelines and the previous icons that you already have merged. I did not find any dedicated pull request on "Indian Rupee" (except #1401), and I could not measure the deviations. With these changes, the stroke widths improved.

BTW, about the DPI (24px) I checked the Rupee symbols in Figma and the symbols that I designed. In the 1px grid, they completely matched in many ways.

Given my current understanding, I believe these modifications will align the design with the guidelines.

I'm afraid every concern raised in my original review still stands: the vertical lines are off grid, gaps are too small, curvatures are uneven (especially for the base icon).

@mayeenulislam
Copy link
Author

@karsa-mistmere I've updated the Icons once again. Pardon me, would love to have another final review.
If not up to the mark, I might discard the pull request by myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata ⚛️ react native package About the React Native package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants