Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): arcified lamp-* icons #2267

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

jguddas
Copy link
Member

@jguddas jguddas commented Jun 28, 2024

What is the purpose of this pull request?

  • Other: Icon update

Description

Arcified lamp icon.

Before Submitting

@github-actions github-actions bot added the 🎨 icon About new icons label Jun 28, 2024
@jguddas jguddas changed the title fix(icons): arcified lamp icon fix(icons): arcified lamp-* icons Jun 28, 2024
Copy link

github-actions bot commented Jul 3, 2024

Added or changed icons

icons/lamp-ceiling.svgicons/lamp-desk.svgicons/lamp-floor.svgicons/lamp-wall-down.svgicons/lamp-wall-up.svgicons/lamp.svg

Preview cohesion icons/square-parking-off.svgicons/message-square-dashed.svgicons/square-m.svgicons/square-minus.svgicons/bot-message-square.svgicons/square-activity.svg
icons/lamp-ceiling.svgicons/lamp-desk.svgicons/lamp-floor.svgicons/lamp-wall-down.svgicons/lamp-wall-up.svgicons/lamp.svg
icons/plane-landing.svgicons/cog.svgicons/bike.svgicons/refresh-ccw-dot.svgicons/align-vertical-distribute-start.svgicons/shopping-cart.svg
Preview stroke widths icons/lamp-ceiling.svgicons/lamp-desk.svgicons/lamp-floor.svgicons/lamp-wall-down.svgicons/lamp-wall-up.svgicons/lamp.svg
icons/lamp-ceiling.svgicons/lamp-desk.svgicons/lamp-floor.svgicons/lamp-wall-down.svgicons/lamp-wall-up.svgicons/lamp.svg
icons/lamp-ceiling.svgicons/lamp-desk.svgicons/lamp-floor.svgicons/lamp-wall-down.svgicons/lamp-wall-up.svgicons/lamp.svg
DPI Preview (24px) icons/lamp-ceiling.svg icons/lamp-desk.svg icons/lamp-floor.svg icons/lamp-wall-down.svg icons/lamp-wall-up.svg icons/lamp.svg
Icon X-rays icons/lamp-ceiling.svg icons/lamp-desk.svg icons/lamp-floor.svg icons/lamp-wall-down.svg icons/lamp-wall-up.svg icons/lamp.svg
Icon Diffs icons/lamp-ceiling.svg icons/lamp-desk.svg icons/lamp-floor.svg icons/lamp-wall-down.svg icons/lamp-wall-up.svg icons/lamp.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const LampCeilingIcon = createLucideIcon('LampCeiling', [
  ["path",{"d":"M12 2v5"}],
  ["path",{"d":"M14.829 15.998a3 3 0 1 1-5.658 0"}],
  ["path",{"d":"M20.92 14.606A1 1 0 0 1 20 16H4a1 1 0 0 1-.92-1.394l3-7A1 1 0 0 1 7 7h10a1 1 0 0 1 .92.606z"}]
])

const LampDeskIcon = createLucideIcon('LampDesk', [
  ["path",{"d":"M10.293 2.293a1 1 0 0 1 1.414 0l2.5 2.5 5.994 1.227a1 1 0 0 1 .506 1.687l-7 7a1 1 0 0 1-1.687-.506l-1.227-5.994-2.5-2.5a1 1 0 0 1 0-1.414z"}],
  ["path",{"d":"m14.207 4.793-3.414 3.414"}],
  ["path",{"d":"M3 20a2 2 0 0 1 2-2h4a2 2 0 0 1 2 2v1a1 1 0 0 1-1 1H4a1 1 0 0 1-1-1z"}],
  ["path",{"d":"m9.086 6.5-4.793 4.793a1 1 0 0 0-.18 1.17L7 18"}]
])

const LampFloorIcon = createLucideIcon('LampFloor', [
  ["path",{"d":"M12 10v12"}],
  ["path",{"d":"M17.929 7.629A1 1 0 0 1 17 9H7a1 1 0 0 1-.928-1.371l2-5A1 1 0 0 1 9 2h6a1 1 0 0 1 .928.629z"}],
  ["path",{"d":"M9 22h6"}]
])

const LampWallDownIcon = createLucideIcon('LampWallDown', [
  ["path",{"d":"M19.929 18.629A1 1 0 0 1 19 20H9a1 1 0 0 1-.928-1.371l2-5A1 1 0 0 1 11 13h6a1 1 0 0 1 .928.629z"}],
  ["path",{"d":"M6 3a2 2 0 0 1 2 2v2a2 2 0 0 1-2 2H5a1 1 0 0 1-1-1V4a1 1 0 0 1 1-1z"}],
  ["path",{"d":"M8 6h4a2 2 0 0 1 2 2v5"}]
])

const LampWallUpIcon = createLucideIcon('LampWallUp', [
  ["path",{"d":"M19.929 9.629A1 1 0 0 1 19 11H9a1 1 0 0 1-.928-1.371l2-5A1 1 0 0 1 11 4h6a1 1 0 0 1 .928.629z"}],
  ["path",{"d":"M6 15a2 2 0 0 1 2 2v2a2 2 0 0 1-2 2H5a1 1 0 0 1-1-1v-4a1 1 0 0 1 1-1z"}],
  ["path",{"d":"M8 18h4a2 2 0 0 0 2-2v-5"}]
])

const LampIcon = createLucideIcon('Lamp', [
  ["path",{"d":"M12 12v6"}],
  ["path",{"d":"M4.077 10.615A1 1 0 0 0 5 12h14a1 1 0 0 0 .923-1.385l-3.077-7.384A2 2 0 0 0 15 2H9a2 2 0 0 0-1.846 1.23Z"}],
  ["path",{"d":"M8 20a2 2 0 0 1 2-2h4a2 2 0 0 1 2 2v1a1 1 0 0 1-1 1H9a1 1 0 0 1-1-1z"}]
])

@karsa-mistmere
Copy link
Member

I think we should adjust for the change in dimensions by making the corners pixel perfect, such as:
image

icons
Open lucide studio

@ericfennis
Copy link
Member

@karsa-mistmere But on the other hand, don't we make it too curvey?

@karsa-mistmere
Copy link
Member

@karsa-mistmere But on the other hand, don't we make it too curvey?

We can use smaller radii where necessary, it's just that we need to stick to the grid more.

Copy link

github-actions bot commented Sep 2, 2024

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Sep 2, 2024
@jamiemlaw
Copy link

I've had a go at nudging the arcs on all those icons so that they sit a little better on the grid.

icons
Open lucide studio

icons
Open lucide studio

icons
Open lucide studio

icons
Open lucide studio

icons
Open lucide studio

icons
Open lucide studio

@github-actions github-actions bot added the 🫧 metadata Improved metadata label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants