-
-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding stretchable alignment icons #2181
base: main
Are you sure you want to change the base?
Conversation
Added or changed iconsIcons as codeWorks for: const AlignHorizontalStretchIcon = createLucideIcon('AlignHorizontalStretch', [
["path",{"d":"M10 9L7 12L10 15"}],
["path",{"d":"M14 9L17 12L14 15"}],
["path",{"d":"M21 22V2"}],
["path",{"d":"M3 22V2"}],
["path",{"d":"M7 12L17 12"}]
])
const AlignVerticalStretchIcon = createLucideIcon('AlignVerticalStretch', [
["path",{"d":"M12 17V7"}],
["path",{"d":"M22 21H2"}],
["path",{"d":"M22 3H2"}],
["path",{"d":"M9 10L12 7L15 10"}],
["path",{"d":"M9 14L12 17L15 14"}]
]) |
Use https://lucide-studio.vercel.app to optimize the icon code. |
✅ |
The icons are a bit big, maybe someone has an idea to get them to be smaller? |
The icons seem a bit large at the ends of the arrows? |
The bounding box is pretty huge, you can also see it here in the |
So I should tighten the arrow? Because the line size is the same as the other alignment icons. |
It's 2px wider than https://lucide.dev/icons/align-horizontal-space-between. The rule for sizing is to keep it similarly sized to |
Okay, I understand the problem now. Is this okay?
Ok, I see the problem. Is it good now? |
I believe there might be an issue with the verification. |
It's good, I have fixed the indentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's to dense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also naming wise we might need to rethink the alignment icons.
What is the purpose of this pull request?
Description
Adding Stretchable Alignment Icons (Vertical and Horizontal)
Icon use case
Alternative icon designs
Icon Design Checklist
Concept
Author, credits & license
The icons are solely my own creation.
The icons were originally created in # by @
I've based them on the following Lucide icons:
move-horizontal
align-horizontal-space-around
I've based them on the following design:
Naming
icons/[iconName].json
.Design
Before Submitting