Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding stretchable alignment icons #2181

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Conversation

MarwanFr
Copy link

@MarwanFr MarwanFr commented Jun 4, 2024

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

Adding Stretchable Alignment Icons (Vertical and Horizontal)

Icon use case

  • Align Horizontal Stretch: This icon could be used to represent horizontal alignment with stretching. For example, it could be used to indicate that an element should stretch horizontally to fill its container.
  • Align Vertical Stretch: This icon could be used to represent vertical alignment with stretching. For example, it could be used to indicate that an element should stretch vertically to fill its container.

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Jun 4, 2024
Copy link

github-actions bot commented Jun 4, 2024

Added or changed icons

icons/align-horizontal-stretch.svgicons/align-vertical-stretch.svg

Preview cohesion icons/square-arrow-left.svgicons/square-divide.svg
icons/align-horizontal-stretch.svgicons/align-vertical-stretch.svg
icons/dam.svgicons/user-round-plus.svg
Preview stroke widths icons/align-horizontal-stretch.svgicons/align-vertical-stretch.svg
icons/align-horizontal-stretch.svgicons/align-vertical-stretch.svg
icons/align-horizontal-stretch.svgicons/align-vertical-stretch.svg
DPI Preview (24px) icons/align-horizontal-stretch.svg icons/align-vertical-stretch.svg
Icon X-rays icons/align-horizontal-stretch.svg icons/align-vertical-stretch.svg
Icon Diffs

icons/align-horizontal-stretch.svg

icons/align-vertical-stretch.svg

Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const AlignHorizontalStretchIcon = createLucideIcon('AlignHorizontalStretch', [
  ["path",{"d":"M10 9L7 12L10 15"}],
  ["path",{"d":"M14 9L17 12L14 15"}],
  ["path",{"d":"M21 22V2"}],
  ["path",{"d":"M3 22V2"}],
  ["path",{"d":"M7 12L17 12"}]
])

const AlignVerticalStretchIcon = createLucideIcon('AlignVerticalStretch', [
  ["path",{"d":"M12 17V7"}],
  ["path",{"d":"M22 21H2"}],
  ["path",{"d":"M22 3H2"}],
  ["path",{"d":"M9 10L12 7L15 10"}],
  ["path",{"d":"M9 14L12 17L15 14"}]
])

@jguddas
Copy link
Member

jguddas commented Jun 4, 2024

Use https://lucide-studio.vercel.app to optimize the icon code.

@MarwanFr
Copy link
Author

MarwanFr commented Jun 4, 2024

@jguddas
Copy link
Member

jguddas commented Jun 5, 2024

The icons are a bit big, maybe someone has an idea to get them to be smaller?

@MarwanFr
Copy link
Author

MarwanFr commented Jun 5, 2024

The icons are a bit big, maybe someone has an idea to get them to be smaller?

The icons seem a bit large at the ends of the arrows?

@jguddas
Copy link
Member

jguddas commented Jun 5, 2024

The icons are a bit big, maybe someone has an idea to get them to be smaller?

The icons seem a bit large at the ends of the arrows?

The bounding box is pretty huge, you can also see it here in the Preview cohesion.

@MarwanFr
Copy link
Author

MarwanFr commented Jun 6, 2024

The icons are a bit big, maybe someone has an idea to get them to be smaller?

The icons seem a bit large at the ends of the arrows?

The bounding box is pretty huge, you can also see it here in the Preview cohesion.

So I should tighten the arrow? Because the line size is the same as the other alignment icons.
image

@jguddas
Copy link
Member

jguddas commented Jun 6, 2024

The icons are a bit big, maybe someone has an idea to get them to be smaller?

The icons seem a bit large at the ends of the arrows?

The bounding box is pretty huge, you can also see it here in the Preview cohesion.

So I should tighten the arrow? Because the line size is the same as the other alignment icons. image

It's 2px wider than https://lucide.dev/icons/align-horizontal-space-between.

The rule for sizing is to keep it similarly sized to square and circle.

@MarwanFr
Copy link
Author

MarwanFr commented Jun 6, 2024

Okay, I understand the problem now. Is this okay?

The icons are a bit big, maybe someone has an idea to get them to be smaller?

The icons seem a bit large at the ends of the arrows?

The bounding box is pretty huge, you can also see it here in the Preview cohesion.

So I should tighten the arrow? Because the line size is the same as the other alignment icons. image

It's 2px wider than https://lucide.dev/icons/align-horizontal-space-between.

The rule for sizing is to keep it similarly sized to square and circle.

Ok, I see the problem. Is it good now?

@MarwanFr
Copy link
Author

MarwanFr commented Jun 9, 2024

I believe there might be an issue with the verification.

icons/align-horizontal-stretch.json Outdated Show resolved Hide resolved
icons/align-vertical-stretch.json Outdated Show resolved Hide resolved
@MarwanFr
Copy link
Author

It's good, I have fixed the indentation.

Copy link
Member

@jguddas jguddas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's to dense.

Copy link
Member

@jguddas jguddas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also naming wise we might need to rethink the alignment icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants