Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/lucid 2.x #44

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Feat/lucid 2.x #44

wants to merge 12 commits into from

Conversation

ksimenic
Copy link

@ksimenic ksimenic commented Jan 13, 2023

This PR doesn't add anything new to lucid. Main purpose of opening this PR is to set standards for future development efforts. Initially it started as a potential solution to #36, but I soon realised that such fixes aren't meant to be backward compatible and won't be maintainable long term.

As a result, I decided to drop support for anything below Laravel 9.x and PHP 8.x. Since new codebase won't work with older PHP versions - mainly because of typehints and return types - my suggestion is to start new version 2.x and (slowly) stop supporting old version.

In the scope of this PR, following changes were done:

  • Dropped support for anything below Laravel 9.x / PHP 8.x, added minimum PHP requirement to composer.json
  • Updated stubs - removing unused ones and updating existing to match newest Laravel generated files
  • Updated existing tests, added new tests and fixed cleanup part
  • Added typehints and return types on all files, removed unneeded dockblock comments on places where parameter types and return types are clear from function declaration
  • Added style fixer (pint)
  • Added static code analysis tool (phpstan)
  • Migrate all commands to extend Laravel command instead of Symfony command
  • Adding PEST, started working on tests - added tests for Str.php
  • Reconfigured actions - added new "Code Quality" job which runs pest, pint and phpstan

Planned future upgrade and standardisation efforts are:

  • Adding more unit tests - Parser, Finder, Filesystem..
  • Adding support for Laravel 10.x and PHP 8.2

as well as actively contributing to solving other reported issues.

- standardise files (type hints, return types, remove docblocks)
- correctly typehint entities
- remove unused code and files
- fix str_replace warning
- remove tests files in delete commands
- add missing delete calls to test-commands.sh
- format strings
- remove unused code
- fix return types
- Added and run laravel pint
- Added Laravel stan, configured it for level 5 and solved all issues
- Rewrite commands to extend Laravel command instead of Symfony command
@ntgraph
Copy link

ntgraph commented Oct 14, 2023

Hi ksimenic,
Will you inform to take over this library? I couldn't contact the creator. As this library plays an important role when we adopt the "lucid way" when we develop applications, we love to make sure this library to be maintained along side Laravel.
I wonder if the Laravel community has relied on this package and why are nobody seem to show interest.
Thanks in advance

@ksimenic
Copy link
Author

@ntgraph sorry man. I completely lost will to do any contributions since this was ignored for such a long time. There is obviously no incentive from authors end to continue contributions so I consider this project abandoned. It is a real pity though, lucid architecture is one of the best architectures I came across in my 10 years of development. If you need any custom work, I will be more than happy to chat!

@ntgraph
Copy link

ntgraph commented Oct 15, 2023

Hi,
I am agree with you about the lucid architecture, I adopt this thinking in all my applications, I heavily use this library and very proud to promote this library to my colleagues. I am sad that the author abandoned. It is not popular may be it is not visible in the Laravel community. I am not at the level of programming library so I can not take over, but I hope you can take over, or someone. And to promote this via Laravel News to have more visibility. Can you create a package and put it at packagist.org to run with Laravel 10? or have your own github, with all the credit of the author and somehow I help to spread the words to pick up the popularity?

@websmurf
Copy link

websmurf commented Nov 2, 2023

I've tried to reach out to @Mulkave through twitter as well, but had little succes.

I wonder if he would be open to others participating in this project to keep it going. In that way there would be a stable basis for the project. I would be able to assist in that matter as well; we use it heavily in a few big projects as well.

Have switched over to your fork for now; but would really like to get this project 'officially' supported again. Have been a fan since the original presentation on Laracon in Amsterdam :-)

@ntgraph
Copy link

ntgraph commented Nov 2, 2023

Can you try in LinkedIn?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants