Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-44488: support code for error-handling in ctrl_mpexec #438

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

TallJimbo
Copy link
Member

@TallJimbo TallJimbo commented Aug 23, 2024

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes (in ctrl_mpexec)

It should be the responsibility of higher-level catching code to
decide whether to log loudly or re-raise instead.
We need this to raise with chaining in the mocks, since that's how
it should always be used in production.
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 81.17%. Comparing base (fe85a52) to head (80c412e).
Report is 3 commits behind head on main.

Files Patch % Lines
...ython/lsst/pipe/base/tests/mocks/_pipeline_task.py 23.07% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #438      +/-   ##
==========================================
- Coverage   81.23%   81.17%   -0.07%     
==========================================
  Files          96       96              
  Lines       10922    10931       +9     
  Branches     2085     2086       +1     
==========================================
  Hits         8873     8873              
- Misses       1691     1699       +8     
- Partials      358      359       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@parejkoj parejkoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume the codecov warnings are mitigated because this code is for the tests in ci_middleware?

@@ -202,7 +202,7 @@ def runQuantum(self, butlerQC, inputRefs, outputRefs):
continue
item.metadata.set_dict("failure", failure_info) # type: ignore

log.exception(
log.debug(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure that we'll still get appropriate outputs in both DRP and AP with this change? I think in AP the full exception will appear, but where will it appear in DRP?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, in DRP SingleQuantumExecutor will emit that "considering this a qualified success" message, following by another warning with the exc_info argument that prints the traceback.

@TallJimbo
Copy link
Member Author

I presume the codecov warnings are mitigated because this code is for the tests in ci_middleware?

Right. The code in lsst.pipe.base.tests.mocks is used for the bulk of ci_middleware and also has its own unit tests in that package. And I've even got the machinery set up to capture the coverage that ci_middleware provides when you run it locally, but there's no way to see it in Jenkins.

@TallJimbo TallJimbo merged commit be41127 into main Aug 28, 2024
11 of 13 checks passed
@TallJimbo TallJimbo deleted the tickets/DM-44488 branch August 28, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants