DM-39661: Rename ButlerQuantumContext to QuantumContext #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #344 +/- ##
==========================================
+ Coverage 82.56% 82.76% +0.19%
==========================================
Files 66 66
Lines 7148 7242 +94
Branches 1394 1293 -101
==========================================
+ Hits 5902 5994 +92
- Misses 1000 1001 +1
- Partials 246 247 +1
☔ View full report in Codecov by Sentry. |
2 tasks
timj
force-pushed
the
tickets/DM-39661
branch
3 times, most recently
from
76863d8
to
682777f
Compare
2 tasks
* Private naming to match expectations. * Preparation for renaming ButlerQuantumContext to QuantumContext
This is in preparation for additional functionality.
pydocstyle is not clever enough to realize that "parameters" in a code block is not Parameters in a numpydoc parameter description.
It's used by analysis_tools for PipelineTaskConfig.applyConfigOverrides so can't be treated as an entirely private API.
This gives more flexibility for the future and makes it easier for this information to be added to ctrl_mpexec APIs.
This allows the dataclass to be strongly typed but allows flexible parameter types to be used for construction.
This lets us take flexible types for the constructor whilst constraining the types for the dataclass.
This is useful when the value is obtained from the command line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes