-
Notifications
You must be signed in to change notification settings - Fork 12
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Coalesce data ID query explanation into a single log.
Logging a single statement as multiple logs causes problems with Loki, because each line may be rearranged or independently filtered. Logging a single multiline message fixes this problem, without changing behavior for console users. Constructing the multiline message makes it impossible to defer string evaluation, but for an error-level log this is unlikely to come up in practice.
- Loading branch information
1 parent
e2fa2c8
commit f6f0254
Showing
2 changed files
with
31 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Explanatory logs for "initial data ID query returned no rows" now appear as a single log message instead of one entry per line. This improves display in log aggregators, but there is no change to console behavior. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters