Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mypy errors from updated sqlalchemy #933

Merged
merged 2 commits into from
Dec 28, 2023
Merged

Fix mypy errors from updated sqlalchemy #933

merged 2 commits into from
Dec 28, 2023

Conversation

dhirving
Copy link
Contributor

@dhirving dhirving commented Dec 28, 2023 •
edited
Loading

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@dhirving
Fix mypy error
3c90ea0 
These are logically two different variables, but the name was previously being re-used.
@dhirving dhirving marked this pull request as draft December 28, 2023 21:40
@dhirving
Fix LogicalColumn mypy error
270740f 
Per Jim, Timespan columns are not expected at this point in the code and would have been throwing an error already if they did show up.
@codecov Codecov
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (747d2cb) 87.94% compared to head (270740f) 87.94%.

Files Patch % Lines
...t/daf/butler/registry/queries/butler_sql_engine.py 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #933      +/-   ##
==========================================
- Coverage   87.94%   87.94%   -0.01%     
==========================================
  Files         301      301              
  Lines       39199    39204       +5     
  Branches     8276     8277       +1     
==========================================
+ Hits        34474    34477       +3     
- Misses       3524     3525       +1     
- Partials     1201     1202       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhirving dhirving marked this pull request as ready for review December 28, 2023 22:05
TallJimbo
TallJimbo approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@dhirving dhirving merged commit 1946ade into main Dec 28, 2023
16 of 18 checks passed
@dhirving dhirving deleted the u/dhirving/mypy-2023-12-28 branch December 28, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallJimbo TallJimbo TallJimbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhirving @TallJimbo