DM-42189: Serve multiple Butler repositories from a single server #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #931 +/- ##
==========================================
+ Coverage 87.99% 88.00% +0.01%
==========================================
Files 309 308 -1
Lines 39468 39452 -16
Branches 8311 8309 -2
==========================================
- Hits 34730 34720 -10
+ Misses 3531 3524 -7
- Partials 1207 1208 +1 ☔ View full report in Codecov by Sentry. |
dhirving
force-pushed
the
tickets/DM-42189
branch
2 times, most recently
from
447f91c
to
ddfe56d
Compare
2 tasks
timj
approved these changes
Jan 2, 2024
| Butler to use. | ||
| repository : `str` | ||
| The label of the Butler repository requested by the user. | ||
|
|
There was a problem hiding this comment.
Numpydoc doesn't need the blank line here.
| index_filename = "repo_index.yaml" | ||
| repo_name = "testserver" | ||
| with open(os.path.join(temp_dir, index_filename), "wb") as fh: | ||
| fh.write(f"{repo_name}: {butler_root}\n".encode()) |
There was a problem hiding this comment.
Suggested change
| fh.write(f"{repo_name}: {butler_root}\n".encode()) | |
| yaml.dump({repo_name: butler_root}, stream=fh) |
?
Yeah, it leaves a free namespace where we can put per-server endpoints, like "list_available_repositories" or "health_check". Otherwise we'd have to worry about repository labels colliding with endpoint names. (Not sure but I wouldn't be surprised if FastAPI doesn't even support having a |
dhirving
force-pushed
the
tickets/DM-42188
branch
from
9e42b8b
to
2d24a30
Compare
dhirving
force-pushed
the
tickets/DM-42189
branch
from
ddfe56d
to
d22addd
Compare
In most environments, users will access multiple Butler repositories (multiple data releases, prompt processing, etc.). To avoid the need to instantiate a separate service for every repository, allow multiple repositories to be hosted from a single server. This uses the same DAF_BUTLER_REPOSITORY_INDEX configuration system as DirectButler.
dhirving
force-pushed
the
tickets/DM-42189
branch
from
d22addd
to
f85bdf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most environments, users will access multiple Butler repositories (multiple data releases, prompt processing, etc.). To avoid the need to instantiate a separate service for every repository, allow multiple repositories to be hosted from a single server.
This uses the same DAF_BUTLER_REPOSITORY_INDEX configuration system as DirectButler.
Checklist
doc/changes