DM-41761: Add Butler.query property #914
Merged
Commits on Dec 6, 2023
-
Add
Butler._querycontext manager (DM-41761)This new method defines an interface for making complex queries on repository database. This initial commit includes only three convenience methods that are a close match to the query methods that already exist in Registry. The implementation of that interface for DirectButler just forwards calls to SqlRegistry. RemoteButler does not implement those methods yet, we will need to define representation for queries and results that client exchanges server. This should become clearer as we add more methods to `Query`.
-
Rename tests/data/registry/datasets-uuid.yaml to datasets.yaml.
As we do not have non-UUID manager anymore, there is no point keeping two dataset.yaml files.
-
Add unit tests for Butler._query convenience methods.
Many tests were just copied from `RegistryTests` to `ButlerQueryTests` replacing calls to registry methods with matching calls to `Butler.query` methods. Tests are implemented for DirectButler only, for both SQLite and Postgres backends.
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.