Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-41724: make dimension record construction more strict #907

Merged
merged 8 commits into from
Nov 17, 2023
Merged

DM-41724: make dimension record construction more strict #907

merged 8 commits into from
Nov 17, 2023

Commits on Nov 17, 2023

  1. Drop subseconds from Timespan.__str__. 

    Timespan.__repr__ has complete information, so we can make __str__ a
bit more concise while still including the information we tend to care
about.
    @TallJimbo
    TallJimbo committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    2c5a9ac View commit details
    Browse the repository at this point in the history

  2. Make timespans and regions more concise in dimension records query CLI. 

    Timespan was messy and quite long, and is now concise.  Regions were
really long and not very useful on the CLI, and are now elided
entirely.

This drops a test workaround for older astropys and bumps the version
in requirements.txt, which is already required in rubin-env.
    @TallJimbo
    TallJimbo committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    9ccc6f2 View commit details
    Browse the repository at this point in the history

  3. Fix bad test data in test utils. 

    datetimeBegin and datetimeEnd have never been recognized as timespan
bounds, but DimensionRecord ignores kwargs it doesn't recognize.
    @TallJimbo
    TallJimbo committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    266cfa8 View commit details
    Browse the repository at this point in the history

  4. Stop coercing DimensionRecord timespans from None to unbounded.

    @TallJimbo
    TallJimbo committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    e0b9246 View commit details
    Browse the repository at this point in the history

  5. Update tests to current visit_system definition in DimensionUniverse. 

    These had gone unnoticed because DimensionRecord silently ignores
kwargs it does not recognize.
    @TallJimbo
    TallJimbo committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    8c57e6b View commit details
    Browse the repository at this point in the history

  6. Add logic for dropping visit.seeing to YAML import. 

    This field is no longer part of the default DimensionUniverse but it's
present in some old YAML exports we want to continue to support.
Right now it's being dropped by virtue of DimensionRecord.__init__
silently ignoring any kwargs it does not recognize, which is not ideal.
    @TallJimbo
    TallJimbo committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    606a716 View commit details
    Browse the repository at this point in the history

  7. Stop ignoring unrecognized kwargs in DimensionRecord.__init__.

    @TallJimbo
    TallJimbo committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    a6b1ffe View commit details
    Browse the repository at this point in the history

  8. Add changelog entry.

    @TallJimbo
    TallJimbo committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    32800dc View commit details
    Browse the repository at this point in the history