-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-34340: implement RFC-834 deprecations #903
Commits on Nov 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 98141ff - Browse repository at this point
Copy the full SHA 98141ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for b39a323 - Browse repository at this point
Copy the full SHA b39a323View commit details -
Add DimensionGroup and deprecate DimensionGraph.
This adds a lot of warnings; DimensionGraph usage will be migrated in later commits. Due to those warnings, one test in test_obscore.py has been temporarily disabled, because it counts warnings, and I couldn't figure out how to make it only count the kind of warning it's actually looking for.
Configuration menu - View commit details
-
Copy full SHA for 2988d2d - Browse repository at this point
Copy the full SHA 2988d2dView commit details -
Add, use Dimension[Universe,Graph,Group] subset attributes.
The confusingly-named DimensionUniverse.getStatic* methods are no longer needed after this, but while I think the middleware team has informally agreed we should drop them and go back to attributes, I don't think that's been RFC'd, so they stay for now. The new skypix attributes help with the other goal here: using set-membership tests rather than isinstance checks in places where we care about different types of dimensions. This will work better when DimensionElement objects appear more rarely, in favor of str names.
Configuration menu - View commit details
-
Copy full SHA for 7cc94a8 - Browse repository at this point
Copy the full SHA 7cc94a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 699fd11 - Browse repository at this point
Copy the full SHA 699fd11View commit details -
Update DataCoordinate interface per RFC-834.
This includes replacing '.graph' with '.dimensions' (to go along with replacing DimensionGraph with DimensionGroup), adding '.mapping' and '.required' to replace '.full', and deprecating Dimension-instance lookup and iteration (which effectively deprecates the Mapping interface).
Configuration menu - View commit details
-
Copy full SHA for 33efabc - Browse repository at this point
Copy the full SHA 33efabcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 71e786a - Browse repository at this point
Copy the full SHA 71e786aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ed29a9b - Browse repository at this point
Copy the full SHA ed29a9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f4b7fa5 - Browse repository at this point
Copy the full SHA f4b7fa5View commit details -
Switch to DimensionGroup in DatasetType and LookupKey.
DatasetType.dimensions needs to continue to return DimensionGraph during the deprecation period, since that's the name we want to use long-term (unlike e.g. DataCoordinate.graph). That means we rely on the fact that we've also deprecated all of the things DimensionGraph can do that DimensionGroup can't do (like iteration), and we rely on those warnings instead of making DatasetType.dimensions itself warn. That should let a lot of usage just blindly pass DatasetType.dimensions to something else and not care about what type it is throughout the deprecation period.
Configuration menu - View commit details
-
Copy full SHA for 2d7feb0 - Browse repository at this point
Copy the full SHA 2d7feb0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 371110a - Browse repository at this point
Copy the full SHA 371110aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d9f226 - Browse repository at this point
Copy the full SHA 0d9f226View commit details -
Configuration menu - View commit details
-
Copy full SHA for a81634d - Browse repository at this point
Copy the full SHA a81634dView commit details -
Deprecate DimensionUniverse.expandDimensionNameSet.
Only usage was in DimensionGraph.
Configuration menu - View commit details
-
Copy full SHA for f4833e1 - Browse repository at this point
Copy the full SHA f4833e1View commit details
Commits on Nov 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6519a1e - Browse repository at this point
Copy the full SHA 6519a1eView commit details -
Add, use DataCoordinate.make_empty.
The old DataCoordinate.makeEmpty is not being deprecated because that wasn't included on RFC-834 and we don't have a good reason to get rid it, but we've now got a consistent suite of DataCoordinate factory methods with from_full_values and from_required_values (whose camelCase forms _did_ have a good reason to be retired, as this aided with the transition from DimensionGraph to DimensionGroup).
Configuration menu - View commit details
-
Copy full SHA for 4d005f7 - Browse repository at this point
Copy the full SHA 4d005f7View commit details