Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-34340: implement RFC-834 deprecations #903

Merged
merged 16 commits into from
Nov 22, 2023
Merged

DM-34340: implement RFC-834 deprecations #903

merged 16 commits into from
Nov 22, 2023

Commits on Nov 20, 2023

  1. Configuration menu
    Copy the full SHA
    98141ff View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b39a323 View commit details
    Browse the repository at this point in the history
  3. Add DimensionGroup and deprecate DimensionGraph.

    This adds a lot of warnings; DimensionGraph usage will be migrated in
    later commits.
    
    Due to those warnings, one test in test_obscore.py has been
    temporarily disabled, because it counts warnings, and I couldn't
    figure out how to make it only count the kind of warning it's actually
    looking for.
    TallJimbo committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    2988d2d View commit details
    Browse the repository at this point in the history
  4. Add, use Dimension[Universe,Graph,Group] subset attributes.

    The confusingly-named DimensionUniverse.getStatic* methods are no
    longer needed after this, but while I think the middleware team has
    informally agreed we should drop them and go back to attributes, I
    don't think that's been RFC'd, so they stay for now.
    
    The new skypix attributes help with the other goal here: using
    set-membership tests rather than isinstance checks in places where
    we care about different types of dimensions.  This will work better
    when DimensionElement objects appear more rarely, in favor of str
    names.
    TallJimbo committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    7cc94a8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    699fd11 View commit details
    Browse the repository at this point in the history
  6. Update DataCoordinate interface per RFC-834.

    This includes replacing '.graph' with '.dimensions' (to go along with
    replacing DimensionGraph with DimensionGroup), adding '.mapping' and
    '.required' to replace '.full', and deprecating Dimension-instance
    lookup and iteration (which effectively deprecates the Mapping
    interface).
    TallJimbo committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    33efabc View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    71e786a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    ed29a9b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f4b7fa5 View commit details
    Browse the repository at this point in the history
  10. Switch to DimensionGroup in DatasetType and LookupKey.

    DatasetType.dimensions needs to continue to return DimensionGraph
    during the deprecation period, since that's the name we want to use
    long-term (unlike e.g. DataCoordinate.graph).  That means we rely on
    the fact that we've also deprecated all of the things DimensionGraph
    can do that DimensionGroup can't do (like iteration), and we rely on
    those warnings instead of making DatasetType.dimensions itself warn.
    That should let a lot of usage just blindly pass
    DatasetType.dimensions to something else and not care about what type
    it is throughout the deprecation period.
    TallJimbo committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    2d7feb0 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    371110a View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    0d9f226 View commit details
    Browse the repository at this point in the history
  13. Rewrap some docstring text.

    TallJimbo committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    a81634d View commit details
    Browse the repository at this point in the history
  14. Deprecate DimensionUniverse.expandDimensionNameSet.

    Only usage was in DimensionGraph.
    TallJimbo committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    f4833e1 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. Configuration menu
    Copy the full SHA
    6519a1e View commit details
    Browse the repository at this point in the history
  2. Add, use DataCoordinate.make_empty.

    The old DataCoordinate.makeEmpty is not being deprecated because that
    wasn't included on RFC-834 and we don't have a good reason to get rid
    it, but we've now got a consistent suite of DataCoordinate factory
    methods with from_full_values and from_required_values (whose camelCase
    forms _did_ have a good reason to be retired, as this aided with the
    transition from DimensionGraph to DimensionGroup).
    TallJimbo committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    4d005f7 View commit details
    Browse the repository at this point in the history