DM-40435: Add fallback check for existence with getDeferred #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for execution butler where datastore doesn't know about files that do exist.
TallJimbo
approved these changes
Aug 18, 2023
In newer pydantic this converts a 0 to 0.0 when serializing to Json and this breaks when reading a record back that is meant to be an integer. This changes in pydantic 2.2 whereas 2.1 behaved like 1.0. This happens because the dynamic subclasses apply dynamic constraints based on the specific record data model so they know that something must be an integer.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #881 +/- ##
=======================================
Coverage 87.70% 87.71%
=======================================
Files 274 274
Lines 36108 36117 +9
Branches 7553 7553
=======================================
+ Hits 31670 31680 +10
Misses 3264 3264
+ Partials 1174 1173 -1
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execution butler doesn't know about these files.
Checklist
doc/changes