Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-39876: Add bandaid for pydantic v2 #859

Merged
merged 6 commits into from
Jul 5, 2023
Merged

DM-39876: Add bandaid for pydantic v2 #859

merged 6 commits into from
Jul 5, 2023

Commits on Jul 4, 2023

  1. Provide None defaults for pydantic parameters

    @timj
    timj committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    d467eaa View commit details
    Browse the repository at this point in the history

  2. Try pydantic v1 API explicitly 

    pydantic v2 is not compatible with daf_butler at the moment.
Change all the imports to first try to load the v1 API explicitly
before falling back to the default API. pydantic.v1 works with
v2.
    @timj
    timj committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    67598c6 View commit details
    Browse the repository at this point in the history

  3. Declare new pydantic pin 

    <3 to protect us against the v3 breakage.
    @timj
    timj committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    8c14f31 View commit details
    Browse the repository at this point in the history

  4. Remove pkg_resources from types install

    @timj
    timj committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    f69e38a View commit details
    Browse the repository at this point in the history

  5. Remove mention of pkg_resources in docs

    @timj
    timj committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    b7a44d6 View commit details
    Browse the repository at this point in the history

  6. Add type: ignore for fallback import 

    This will only work in pydantic v2 with mypy but typing with
pydantic is already broken with v1 with the changes on this
branch.
    @timj
    timj committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    9851811 View commit details
    Browse the repository at this point in the history