DM-39696: Minor cleanup of test warnings #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were removed from the other registry implementations long ago.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #853 +/- ##
==========================================
+ Coverage 87.98% 88.01% +0.03%
==========================================
Files 269 269
Lines 35435 35417 -18
Branches 7429 7423 -6
==========================================
- Hits 31178 31173 -5
+ Misses 3114 3103 -11
+ Partials 1143 1141 -2
☔ View full report in Codecov by Sentry. |
On python 3.11 the previous code gave a warning:
tests/test_cliUtils.py::MWOptionDecoratorTest::test_option
.../python3.11/unittest/case.py:678: DeprecationWarning: It is deprecated to return a value
that is not None from a test case (<lsst.daf.butler.cli.utils.MWOptionDecorator object at 0x2ae76e790>)
return self.run(*args, **kwds)
|
The new v1.4.0 mypy error is: python/lsst/daf/butler/_butler.py:1657: error: Unsupported operand types for | ("Literal[DatasetExistence.RECORDED]" and "Literal[DatasetExistence._ASSUMED]") [operator]
python/lsst/daf/butler/_butler.py:1657: error: Unsupported operand types for | ("Literal[DatasetExistence.DATASTORE]" and "Literal[DatasetExistence._ASSUMED]") [operator]
python/lsst/daf/butler/_butler.py:1657: error: Unsupported operand types for | ("Literal[DatasetExistence._ARTIFACT]" and "Literal[DatasetExistence._ASSUMED]") [operator]
python/lsst/daf/butler/_butler.py:1657: error: Unsupported operand types for | ("Literal[DatasetExistence.KNOWN]" and "Literal[DatasetExistence._ASSUMED]") [operator]
python/lsst/daf/butler/_butler.py:1657: error: Unsupported operand types for | ("Literal[DatasetExistence.VERIFIED]" and "Literal[DatasetExistence._ASSUMED]") [operator]
python/lsst/daf/butler/_butler.py:1657: note: Left operand is of type "Literal[DatasetExistence.RECORDED, DatasetExistence.DATASTORE, DatasetExistence._ARTIFACT, DatasetExistence._ASSUMED, DatasetExistence.KNOWN, DatasetExistence.VERIFIED]"and I'm guessing that mypy is not clever to understand that different flags can be or-ed together. @andy-slac should I add an ignore annotation or does something jump out at you? |
Now always assume that we have one DatasetId type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes