DM-47475: Fix crash in some find_first queries in the new query system. #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-slac
force-pushed
the
tickets/DM-47475
branch
from
636701a
to
632371a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1115 +/- ##
=======================================
Coverage 89.41% 89.41%
=======================================
Files 363 363
Lines 48423 48440 +17
Branches 5879 5879
=======================================
+ Hits 43296 43315 +19
+ Misses 3717 3716 -1
+ Partials 1410 1409 -1 ☔ View full report in Codecov by Sentry. |
TallJimbo
approved these changes
Nov 11, 2024
Find-first follow-up queries caused crash in some conditions in QG builder due to a missing postprocessing parameter. The fix is one-liner, and this patch adds a unit test which reproduces the crash with more than one run collection.
andy-slac
force-pushed
the
tickets/DM-47475
branch
from
632371a
to
b2784ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find-first follow-up queries caused crash in some conditions in QG builder due to a missing postprocessing parameter. The fix is one-liner, and this patch adds a unit test which reproduces the crash with more than one run collection.
Checklist
doc/changesconfigs/old_dimensions