Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-46631: fix replace=True on dimensions (etc) with only primary key columns #1106

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

TallJimbo
Copy link
Member

@TallJimbo TallJimbo commented Oct 23, 2024

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.71%. Comparing base (ddf0c64) to head (e75146c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1106   +/-   ##
=======================================
  Coverage   89.71%   89.71%           
=======================================
  Files         360      360           
  Lines       47434    47451   +17     
  Branches     5732     5734    +2     
=======================================
+ Hits        42554    42571   +17     
  Misses       3518     3518           
  Partials     1362     1362           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

python/lsst/daf/butler/registry/tests/_database.py Outdated Show resolved Hide resolved
This is especially common in tables where the only columns are primary
keys.
@TallJimbo TallJimbo merged commit 84471a8 into main Oct 23, 2024
18 checks passed
@TallJimbo TallJimbo deleted the tickets/DM-46631 branch October 23, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants